NJ 44 - update NJ voucher info #5301
Open
+12
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heroku app: https://gyr-review-app-5301-a9c919bc8ff1.herokuapp.com/ |
mluedke2
approved these changes
Dec 30, 2024
jachan
approved these changes
Dec 30, 2024
jachan
reviewed
Dec 30, 2024
|
@mluedke2 Not entirely sure how to test it (I think Amani is doing that) but all info I have points to just using the path for the voucher. It's the same thing other states are doing, and the ticket included this comment 
|
mpidcock
reviewed
Dec 31, 2024
There was a problem hiding this comment.
[pebble] Because voucher pdfs are served to the user without being filled, it needs to be moved to /public/pdfs/. Apologies that this is confusing and not documented!
mpidcock
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to pivotal/JIRA issue
https://github.com/newjersey/affordability-pm/issues/44
Is PM acceptance required? (delete one)
What was done?
How to test?
n/a
Screenshots (for visual changes)
n/a