NJ 190 - update household rent/own screen with description and reveals #5302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heroku app: https://gyr-review-app-5302-68fb5f37e63e.herokuapp.com/ |
mpidcock
approved these changes
Dec 31, 2024
mmazanec22
approved these changes
Jan 3, 2025
mluedke2
reviewed
Jan 3, 2025
| { value: :both, label: t(".both") }, | ||
| { value: :neither, label: t(".neither") }, | ||
| ], | ||
| legend_class: "sr-only" |
There was a problem hiding this comment.
[dust] what are the reasons/implications around removing legend_class: "sr-only"? from the screenshots it looks fine to me so I don't think it blocks, but just wondering why.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to pivotal/JIRA issue
https://github.com/newjersey/affordability-pm/issues/190
Is PM acceptance required? (delete one)
What was done?
Update content and add reveals
How to test?
any persona. advance to household rent/own screen
Screenshots (for visual changes)