first stab at a data backfill for StateFileArchivedIntake #5305
Conversation
|
Heroku app: https://gyr-review-app-5305-3f92ceae63ac.herokuapp.com/ |
…off date configurable; this will help in testing where we won't reliably have accepted returns with transition dates before the 'real' ty23 cutoff of may-ish 2024
| @@ -0,0 +1,74 @@ | |||
| module StateFile | |||
There was a problem hiding this comment.
at a high level, i think it would be helpful to write tests for this file.
| next | ||
| end | ||
| Rails.logger.info("Archived #{archived_ids.count} #{data_source} intakes: [#{archived_ids.join(', ')}]") | ||
| @current_batch = nil # reset the batch |
There was a problem hiding this comment.
why is the @current_batch set to nil for this method?
There was a problem hiding this comment.
ah, i think it is to exit the while loop in the rake task.
| next | ||
| end | ||
| Rails.logger.info("Archived #{archived_ids.count} #{data_source} intakes: [#{archived_ids.join(', ')}]") | ||
| @current_batch = nil # reset the batch |
There was a problem hiding this comment.
ah, i think it is to exit the while loop in the rake task.
| archive = StateFileArchivedIntake.new(record.without('source_intake_id')) | ||
| archive.submission_pdf.attach(data_source.find(record['source_intake_id']).submission_pdf.blob) | ||
| archive.save! | ||
| archived_ids << record['source_intake_id'] |
There was a problem hiding this comment.
🤔 i am assuming that we don't want to archive and delete in the same rake task.
maybe it would be helpful to have a method that after the archive_batch is run, we verify that the archivable intakes now have an archivable record.
i don't if that makes sense or is easy.
There was a problem hiding this comment.
also how were you thinking of recording the intake IDs for deleting? or were you thinking of running the query again and then deleting them?
|
also, the annotate error should be resolved if you merge in |
| #{tax_year} AS tax_year, '#{state_code}' AS state_code, | ||
| email_address, hashed_ssn, id AS source_intake_id | ||
| FROM | ||
| state_file_az_intakes |
There was a problem hiding this comment.
🤔 just realized this query is just for AZ. since this is a WIP PR, i'm sure you were gonna change this, but just pointing out for other reviewers.
Link to pivotal/JIRA issue
Is PM acceptance required? (delete one)
Reminder: merge main into this branch and get green tests before merging to main
What was done?
How to test?
Screenshots (for visual changes)