Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update new member resources to help with onboarding #124

Merged
merged 5 commits into from
Feb 12, 2018

Conversation

wdoug
Copy link
Member

@wdoug wdoug commented Feb 5, 2018

NOTE: This pull request is based on top of #123 We'll want to merge that one first

This PR closes #97

What does this PR do?

  • Adds an initial markdown renderer component
  • Updates the new member resources document and converts it to markdown for easier updating
  • Adds separation of logged-in routes and logged-out routes
  • Makes new landing page for when the user hasn't logged in

Hopefully this will help in our quest to automate onboarding

How does this PR make you feel? 🔗

@wdoug
Copy link
Member Author

wdoug commented Feb 5, 2018

This can be seen here. Make sure you copy and past in the url https://deploy-preview-124--cfd-members.netlify.com/ before the # right after you log in to be able to log in to the actual review app.

@eemshi
Copy link
Member

eemshi commented Feb 8, 2018

hey @wdoug, just fyi, pasting https://deploy-preview-124--cfd-members.netlify.com/ before the # in the url right after logging in didn't do anything for me (still not showing me as logged in)

edit: it worked after a couple of tries and logging in several times. i think the same thing happened with the login the last time i looked at this (last month?) so maybe it's already logged as a separate bug?

ok, just tried again a couple times in new incognito browsers and it seems to be working. must've been a fluke the first time.

- Task management built on top of github issues
- [Flowdock](https://www.flowdock.com/app/cfa-brigades/code-for-denver)
- Chat tool
- Requires an invite from and admin to our organization
Copy link
Member

@eemshi eemshi Feb 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiniest typo: "an admin of"

@wdoug wdoug force-pushed the 97_update_new_member_resources branch from 525ea86 to 20f1bb1 Compare February 9, 2018 03:11
@wdoug
Copy link
Member Author

wdoug commented Feb 9, 2018

@eemshi, in regards to the log in issue, there is a known funky situation when a user logs in or signs up. I was thinking it was documented in #91, but I think that might be something else so I went ahead and created a new issue: #127

@wdoug wdoug force-pushed the 97_update_new_member_resources branch from 20f1bb1 to 8534c2a Compare February 9, 2018 03:58
Copy link
Member

@dviramontes dviramontes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

sanitize: true // DO NOT CHANGE - helps avoid XSS attack possibility
});

async function getMarkdownHTML(fileName) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice async await function!

@wdoug wdoug merged commit 7f26c29 into master Feb 12, 2018
@wdoug wdoug deleted the 97_update_new_member_resources branch February 12, 2018 05:26
@wdoug wdoug removed the in progress label Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

For new members, update info on tools CfD uses
3 participants