Disable all commands for change if connection is readonly

[chrjorgensen]

Changes

This PR will disable all commands used for changing content on the server, if the connection is marked readonly.
This include terminals and run of actions, but not library list change command or action management etc.

EDIT: C4i will now ask for reload when the readonly value changes in the config.

EDIT: The readonly field has been moved to the Features section as the first option:

EDIT: The readonly connection setting is decribed in the PR #71 in the Docs repo.

EDIT: Save As will now fail with filesystem error if the connection is in readonly mode.

How to test this PR

1. Open a connection marked as readonly
2. No commands for changing server content should not be available and greyed out in the context menus
3. Change the connection config, unmark readonly and reconnect.
4. The commands for changing server content should now be available as usual.

Checklist

• have tested my change
• updated relevant documentation

[worksofliam]

Only one issue I found:

The deploy command still works even in readonly mode (should be a simple package.json addition)

Once that's done, I think we can merge.

Great work!

[worksofliam]

@chrjorgensen I saw you mentioned you're on holiday - let me take over this PR for you.

[worksofliam]

@sebjulliand I've added one small commit to this PR. Any chance you can have a review?

[sebjulliand]

Looks good and works fine overall @chrjorgensen , that's great; this is true protection 😉
However, I have a remark about the actions.
Also, (but that's a question) It seems odd that even opening a terminal is disabled. I know you can wreck havoc with a terminal, but not being able to open one in this context seems a bit too much. That's up for debate!

[sebjulliand]

I'm not sure about disabling Run Action entirely since the actions will be disabled when in read-only anyway, unless the "Enable in protected mode" option is enabled on the action. Disabling it entirely bypasses this option.

[chrjorgensen]

See my comment below...

[chrjorgensen]

@sebjulliand Thanks for reviewing this - but there is no such thing as true protection! 😉

I gave this change a lot of thoughts - mostly from a system administrators point of view... and I think we should not leave any options open for the C4i user if the admin has defined the system as readonly in the systemwide settings file /etcvscode/settings.json`.

Allowing actions in readonly mode gives the user the option to create a new action, which circumvent the protection, e.g. RMVM, DLTPGM etc. The same goes for the terminals.

So this PR is created by a system admin 😅 and may seem harsh in its implementation. I'm open for a more granular control, distinguishing between system wide readonly and user defined readonly. This could be added in another PR?

Thoughts? 😃