Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSBridge-Core-ct.11: Fix superclass of JSException #155

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,5 @@
"name" : "JSException",
"pools" : [
],
"super" : "Exception",
"super" : "Error",
"type" : "normal" }
2 changes: 1 addition & 1 deletion utils/JSBridge-Core.package/monticello.meta/version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
(name 'JSBridge-Core-WRB.10' message 'Adding JSObjectProxy>>await: and JSException' id '69afd132-a503-4929-9f93-aed877870ea1' date '27 April 2020' time '10:24:50.624537 am' author 'WRB' ancestors ((name 'JSBridge-Core-bf.9' message 'Change examples to use promises' id '39285135-be54-4a0c-9acf-28eeb457ecc1' date '12 July 2016' time '9:06:59.077 pm' author 'bf' ancestors ((name 'JSBridge-Core-bf.8' message 'add asJSObject to pass Squeak objects to JS' id '0643fea0-c60d-4680-bd66-8b2fdece4873' date '30 January 2015' time '1:22:04.892 pm' author 'bf' ancestors ((name 'JSBridge-Core-bf.7' message 'JQuery button callback example' id '33a6dce1-179e-4069-8025-bf004b2e404f' date '4 December 2014' time '11:17:23.729 pm' author 'bf' ancestors ((name 'JSBridge-Core-bf.6' message 'Add support for blocks as callbacks' id '6d73da17-f2b1-4797-949d-838bf1e13eb6' date '28 November 2014' time '11:28:37.104 pm' author 'bf' ancestors ((name 'JSBridge-Core-bf.5' message 'Send #asJSArgument if plugin fails to convert args own its own.' id '3d0cc04c-ade2-46b8-b8cb-eeb64108191d' date '25 November 2014' time '9:15:48.177 pm' author 'bf' ancestors ((name 'JSBridge-Core-bf.4' message 'Rename JS to JSObjectProxy and make JS a regular JSObjectProxy instance instead. This gets rid of the class-side weirdness.' id 'c99f451d-3b63-4cf0-a652-c908f94d070f' date '24 November 2014' time '4:09:11.519 pm' author 'bf' ancestors ((name 'JSBridge-Core-bf.3' message 'Ensure the compiler does not optimize away the named primitive spec, but still makes it the first literal.' id '5ecb1497-06dd-4944-954a-57eb2c37b8b7' date '23 November 2014' time '5:31:34.691 pm' author 'bf' ancestors ((name 'JSBridge-Core-bf.2' message 'open workspace on loading (only if JavaScriptPlugin is available)' id '7c762eed-9652-468f-9180-e25ee5abfb4d' date '21 November 2014' time '7:01:12.362 pm' author 'bf' ancestors ((name 'JSBridge-Core-bf.1' message 'Initial revision' id '61aa28b3-2b0b-40c4-aba4-81c081ac637b' date '21 November 2014' time '4:29:38.782 pm' author 'bf' ancestors () stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())
(name 'JSBridge-Core-ct.11' message 'Fix superclass of JSExceptionOne should (always) never subclass from Exception itself, but most of the time from Error or Notification or one of its subclasses. Exception is an abstract class, and the previous implementation led to SubclassResponsibility errors from Exception>>defaultAction when signaling a JSException. Since JavaScript errors do not have Smalltalk''s coroutine capabilities, subclassing from Error seems a perfect match in this case.' id 'ef0a6c94-b56f-3948-861a-a1a5a7bc8623' date '23 January 2024' time '8:26:40.068411 pm' author 'ct' ancestors ((name 'JSBridge-Core-WRB.10' message 'Adding JSObjectProxy>>await: and JSException' id '69afd132-a503-4929-9f93-aed877870ea1' date '27 April 2020' time '10:24:50.624537 am' author 'WRB' ancestors ((name 'JSBridge-Core-bf.9' message 'Change examples to use promises' id '39285135-be54-4a0c-9acf-28eeb457ecc1' date '12 July 2016' time '9:06:59.077 pm' author 'bf' ancestors ((name 'JSBridge-Core-bf.8' message 'add asJSObject to pass Squeak objects to JS' id '0643fea0-c60d-4680-bd66-8b2fdece4873' date '30 January 2015' time '1:22:04.892 pm' author 'bf' ancestors ((name 'JSBridge-Core-bf.7' message 'JQuery button callback example' id '33a6dce1-179e-4069-8025-bf004b2e404f' date '4 December 2014' time '11:17:23.729 pm' author 'bf' ancestors ((name 'JSBridge-Core-bf.6' message 'Add support for blocks as callbacks' id '6d73da17-f2b1-4797-949d-838bf1e13eb6' date '28 November 2014' time '11:28:37.104 pm' author 'bf' ancestors ((name 'JSBridge-Core-bf.5' message 'Send #asJSArgument if plugin fails to convert args own its own.' id '3d0cc04c-ade2-46b8-b8cb-eeb64108191d' date '25 November 2014' time '9:15:48.177 pm' author 'bf' ancestors ((name 'JSBridge-Core-bf.4' message 'Rename JS to JSObjectProxy and make JS a regular JSObjectProxy instance instead. This gets rid of the class-side weirdness.' id 'c99f451d-3b63-4cf0-a652-c908f94d070f' date '24 November 2014' time '4:09:11.519 pm' author 'bf' ancestors ((name 'JSBridge-Core-bf.3' message 'Ensure the compiler does not optimize away the named primitive spec, but still makes it the first literal.' id '5ecb1497-06dd-4944-954a-57eb2c37b8b7' date '23 November 2014' time '5:31:34.691 pm' author 'bf' ancestors ((name 'JSBridge-Core-bf.2' message 'open workspace on loading (only if JavaScriptPlugin is available)' id '7c762eed-9652-468f-9180-e25ee5abfb4d' date '21 November 2014' time '7:01:12.362 pm' author 'bf' ancestors ((name 'JSBridge-Core-bf.1' message 'Initial revision' id '61aa28b3-2b0b-40c4-aba4-81c081ac637b' date '21 November 2014' time '4:29:38.782 pm' author 'bf' ancestors () stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())
Expand Down