Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(event-reporter): refactoring, variables grouping, code splitting #351

Merged
merged 10 commits into from
Nov 7, 2024
Merged

chore(event-reporter): refactoring, variables grouping, code splitting #351

merged 10 commits into from
Nov 7, 2024

Conversation

oleksandr-codefresh
Copy link

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@oleksandr-codefresh oleksandr-codefresh changed the title chore(event-handler): refactoring, variables grouping, code splitting chore(event-reporter): refactoring, variables grouping, code splitting Nov 7, 2024
pasha-codefresh
pasha-codefresh requested changes Nov 7, 2024
View reviewed changes
event_reporter/reporter/application_event_reporter.go Outdated
func (s *applicationEventReporter) resolveApplicationVersions(ctx context.Context, a *appv1.Application, logCtx *log.Entry) *apiclient.ApplicationVersions {
syncRevision := utils.GetOperationStateRevision(a)
var applicationVersions *apiclient.ApplicationVersions
if syncRevision != nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets rid of else condition and make it nicer. also you dont need applicationVersions as variable

event_reporter/reporter/event_payload.go Outdated
) ([]byte, error) {
// no actual or desired state, don't send event
u := &unstructured.Unstructured{}
apiVersion := rr.rs.Version
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create function inside ReportedResource that will build you api version, like rr.rs.GetApiVersion

@oleksandr-codefresh oleksandr-codefresh force-pushed the CR-23668-refactoring-variables-grouping branch from c42708b to 5230e16 Compare November 7, 2024 15:26
@oleksandr-codefresh oleksandr-codefresh merged commit 5af7ecc into release-2.12 Nov 7, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pasha-codefresh pasha-codefresh pasha-codefresh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oleksandr-codefresh @pasha-codefresh