Skip to content

Commit

Permalink
Add a log message in case of hosted runtime uninstall (#739)
Browse files Browse the repository at this point in the history
## What
<!-- What is changing in this PR? -->

## Why
<!-- Why are these changes being made? -->

## Notes
<!-- Add any additional notes here -->
  • Loading branch information
danielm-codefresh authored Feb 24, 2024
1 parent 67fda7a commit 6f3f1e8
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 7 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
VERSION=v0.1.61
VERSION=v0.1.62

OUT_DIR=dist
YEAR?=$(shell date +"%Y")
Expand Down
6 changes: 2 additions & 4 deletions cmd/commands/runtime.go
Original file line number Diff line number Diff line change
Expand Up @@ -578,11 +578,9 @@ func runRuntimeUninstall(ctx context.Context, opts *RuntimeUninstallOptions) err
return err
}

log.G(ctx).Infof("Deleting runtime \"%s\" from platform", opts.RuntimeName)
err = deleteRuntimeFromPlatform(ctx, opts)
if opts.Managed {
_, err = cfConfig.NewClient().GraphQL().Runtime().DeleteManaged(ctx, opts.RuntimeName)
} else {
err = deleteRuntimeFromPlatform(ctx, opts)
log.G(ctx).Infof("It may take up to 5 minutes until your hosted runtime will be fully deleted")
}
handleCliStep(reporter.UninstallStepDeleteRuntimeFromPlatform, "Deleting runtime from platform", err, false, !opts.Managed)
if err != nil {
Expand Down
4 changes: 2 additions & 2 deletions docs/releases/release_notes.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ cf version

```bash
# download and extract the binary
curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.1.61/cf-linux-amd64.tar.gz | tar zx
curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.1.62/cf-linux-amd64.tar.gz | tar zx

# move the binary to your $PATH
mv ./cf-linux-amd64 /usr/local/bin/cf
Expand All @@ -36,7 +36,7 @@ cf version

```bash
# download and extract the binary
curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.1.61/cf-darwin-amd64.tar.gz | tar zx
curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.1.62/cf-darwin-amd64.tar.gz | tar zx

# move the binary to your $PATH
mv ./cf-darwin-amd64 /usr/local/bin/cf
Expand Down

0 comments on commit 6f3f1e8

Please sign in to comment.