chore: removed dependency on argocd-autopilot #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ATGardner
requested review from
danielm-codefresh and
pasha-codefresh
as code owners
dmaizel
approved these changes
Mar 25, 2025
* update version to `v0.2.0` * upgraded github.com/codefresh-io/go-sdk v1.3.1 => v1.3.4 * replaced github.com/ghodss/yaml with sigs.k8s.io/yaml * updated helm.sh/helm/v3 v3.8.0-rc.1.0.20220506100945-5c256a5e7d55 => v3.15.3 * k8s.io/* v0.26.11 => 0.29.6 * upgraded sigs.k8s.io/kustomize/api v0.12.1 => v0.17.3 * upgraded sigs.k8s.io/kustomize/kyaml v0.13.9 => v0.17.3 * upgraded github.com/fatih/color v1.16.0 => v1.17.0 * upgraded github.com/argoproj/argo-cd/v2 v2.12.3 => v2.13.0 * upgraded github.com/codefresh-io/go-sdk v1.3.4 => v1.4.0 * upgrade github.com/fatih/color v1.17.0 => v1.18.0 * upgrade sigs.k8s.io/kustomize/api v0.17.3 => v0.18.0 * use single runtime, instead of showing a 1-line selection to the user
…function Updated the Wait function to use PollUntilContextTimeout for better context handling. This change improves the function's ability to respect context cancellation and timeout settings.
ATGardner
added a commit
that referenced
this pull request
Apr 7, 2025
## What * Updated the getAppProxyClient function to accept a pointer for the runtime parameter. * Removed unused app proxy version retrieval logic from the newVersionCommand function to clean up the code and improve maintainability. ## Why using the pointer ensures the appproxy Client connects to the runtime supplied in the `--runtime` flag ## Notes the original issue originated from #757
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
removed dependencies:
updated dependencies:
replaced github.com/ghodss/yaml with sigs.k8s.io/yaml
Why
no need to commit any files to any git repository anymore, all operations are actually done in app-proxy.
Notes