implements the project list #16
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| { | ||
| "go.testFlags": ["-v"] | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| package codefresh | ||
|
|
||
| type ( | ||
| IProjectAPI interface { | ||
| List() ([]*Project, error) | ||
| } | ||
| project struct { | ||
| codefresh Codefresh | ||
| } | ||
| Project struct { | ||
| ProjectName string `json:"projectName"` | ||
| pipelineNumber int `json:"pipelineNumber"` | ||
| } | ||
| getProjectResponse struct { | ||
| Total int `json:"limit"` | ||
| Projects []*Project `json:"projects"` | ||
| } | ||
| ) | ||
|
|
||
| func newProjectAPI(codefresh Codefresh) IProjectAPI { | ||
| return &project{codefresh} | ||
| } | ||
|
|
||
| func (p *project) List() ([]*Project, error) { | ||
| r := &getProjectResponse{} | ||
| resp, err := p.codefresh.requestAPI(&requestOptions{ | ||
| path: "/api/projects", | ||
| method: "GET", | ||
| }) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| err = p.codefresh.decodeResponseInto(resp, r) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| return r.Projects, nil | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| package codefresh | ||
|
|
||
| import ( | ||
| "testing" | ||
|
|
||
| "github.com/stretchr/testify/assert" | ||
| ) | ||
|
|
||
| var clientOptions = ClientOptions{ | ||
| Auth: AuthOptions{ | ||
| Token: "", | ||
| }, | ||
| Debug: true, | ||
| Host: "https://g.codefresh.io", | ||
| } | ||
|
|
||
| func TestProject(t *testing.T) { | ||
|
|
||
| cf := New(&clientOptions) | ||
|
There was a problem hiding this comment. maybe you can use the codefresh/mock/codefresh struct to make this test better? There was a problem hiding this comment. @noam-codefresh is there an example that shows the coddfresh mock structs use. For an API client that should have been code generated, this abstraction is proving to be rather tedious, and hard to follow, it most certainly confuses the compiler |
||
| projects, err := cf.Projects().List() | ||
| if err != nil { | ||
| t.Fatal(err) | ||
| } | ||
| assert.NotEqual(t, len(projects), 0) | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please do not include this file in the pr
I see the repo doesn't have a .gitignore file - maybe even include one that ignores visual studio code and golang artifacts? (just a suggestion)