-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ability to override default image #709
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Seth Pollack <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Set metadata.version to 1.1.13
I would write the step simply using a default value aka:
then the step can simply be: steps/incubating/service-now/step.yaml Line 82 in 1f3433e
steps/incubating/service-now/step.yaml Line 176 in 1f3433e
|
@lrochette how would you deal with the |
I would not, you can simply override the image parameter with your debian image as @vadim-kharin-codefresh mentioned |
Then we cant set a default for the debian image anymore. |
No you just pass it as a parameter |
Add ability to override default image.
Allows users to add extra tooling without needing to build a custom step.
Example use case would be post-rendering