Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ability to override default image #709

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sethpollack
Copy link

Add ability to override default image.

Allows users to add extra tooling without needing to build a custom step.

Example use case would be post-rendering

Copy link
Contributor

@vadim-kharin-codefresh vadim-kharin-codefresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set metadata.version to 1.1.13

@lrochette
Copy link
Contributor

I would write the step simply using a default value aka:

"image": { "type": "string", "description": "Override the default image used for the step", "default": "quay.io/codefreshplugins/cfstep-helm" }

then the step can simply be:
main: name: helm image: [[ .Arguments.image ]]:[[ .Arguments.helm_version ]]
This is how I wrote all my steps (See

and
image: '[[.Arguments.SN_IMAGE]]:[[.Arguments.SN_IMAGE_VERSION]]'
for a complete example)

@sethpollack
Copy link
Author

@lrochette how would you deal with the use_debian_image in that case?

@lrochette
Copy link
Contributor

@lrochette how would you deal with the use_debian_image in that case?

I would not, you can simply override the image parameter with your debian image as @vadim-kharin-codefresh mentioned

@sethpollack
Copy link
Author

Then we cant set a default for the debian image anymore.

@cf-training
Copy link

Then we cant set a default for the debian image anymore.

No you just pass it as a parameter
Other option would be to create your own step

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants