Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

recursive submodule fix #2

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

recursive submodule fix #2

wants to merge 4 commits into from

Commits on May 14, 2020

  1. correct error exit status

    @vasily-codefresh
    vasily-codefresh committed May 14, 2020
    Configuration menu
    Copy the full SHA
    871fc5b View commit details
    Browse the repository at this point in the history

  2. fix recursive submodules 

    currently we depend on a hack that uses sed to enforce https, not git for github.
this doesn't work for submodules.

re-doing this hack with a `git config` instead
    @vasily-codefresh
    vasily-codefresh committed May 14, 2020
    Configuration menu
    Copy the full SHA
    95e55b4 View commit details
    Browse the repository at this point in the history

  3. it looks like we don't need ssh hack, as we don't use ssh

    @vasily-codefresh
    vasily-codefresh committed May 14, 2020
    Configuration menu
    Copy the full SHA
    9c21e18 View commit details
    Browse the repository at this point in the history

  4. codestyle (4 spaces for indent, not a mix of 4 and 2)

    @vasily-codefresh
    vasily-codefresh committed May 14, 2020
    Configuration menu
    Copy the full SHA
    0f30df7 View commit details
    Browse the repository at this point in the history