apply Copilot review

Author: paulbalandan

system/HTTP/Exceptions/RedirectException.php

@@ -27,7 +27,7 @@
 class RedirectException extends RuntimeException implements ExceptionInterface, ResponsableInterface, HTTPExceptionInterface
 {
     /**
-     * Status code applied to a Response that arrives without a 3xx redirect status.
+     * Status code applied to a Response whose status is outside the 301-308 range.
      */
     protected int $defaultStatusCode = 302;
 

tests/system/HTTP/RedirectExceptionTest.php

@@ -76,6 +76,18 @@ public function testResponseWithoutStatusCode(): void
         $this->assertSame(302, $response->getStatusCode());
     }
 
+    public function testResponseWithoutStatusCodeUsesSubclassDefault(): void
+    {
+        $exception = new class (service('response')->setHeader('Location', 'location')) extends RedirectException {
+            protected int $defaultStatusCode = 307;
+        };
+
+        $response = $exception->getResponse();
+
+        $this->assertSame('location', $response->getHeaderLine('location'));
+        $this->assertSame(307, $response->getStatusCode());
+    }
+
     public function testLoggingLocationHeader(): void
     {
         Time::setTestNow('2023-11-25 12:00:00');

user_guide_src/source/changelogs/v4.8.0.rst

@@ -42,7 +42,7 @@ Behavior Changes
 - **Filters:** HTTP method matching for method-based filters is now case-sensitive. The keys in ``Config\Filters::$methods`` must exactly match the request method
   (e.g., ``GET``, ``POST``). Lowercase method names (e.g., ``post``) will no longer match.
 - **HTTP:** Routes defined with ``$routes->add()`` now also match HTTP ``QUERY`` requests. If the route has CSRF protection, remember that CSRF verification does not protect safe methods such as ``GET`` and ``QUERY``.
-- **HTTP:** ``CodeIgniter\HTTP\Exceptions\RedirectException`` no longer redeclares the inherited ``$code`` property. The status applied to a ``Response`` passed to the constructor without a 3xx status now comes from the new ``protected int $defaultStatusCode = 302`` property. Subclasses that overrode ``$code`` to change that status must override ``$defaultStatusCode`` instead.
+- **HTTP:** ``CodeIgniter\HTTP\Exceptions\RedirectException`` no longer redeclares the inherited ``$code`` property. The status applied to a ``Response`` passed to the constructor whose status is outside the 301-308 range now comes from the new ``protected int $defaultStatusCode = 302`` property. Subclasses that overrode ``$code`` to change that status must override ``$defaultStatusCode`` instead.
 - **Testing:** Tests using the ``FeatureTestTrait`` must now use uppercase HTTP method names when performing a request when using the ``call()`` method directly
   (e.g., ``$this->call('GET', '/path')`` instead of ``$this->call('get', '/path')``). Additionally, setting method-based routes using ``withRoutes()`` must
   also use uppercase method names (e.g., ``$this->withRoutes([['GET', 'home', 'Home::index']])``).

user_guide_src/source/installation/upgrade_480.rst

@@ -82,6 +82,27 @@ the URI. Such calls must now pass a ``URI``:
 Any other call that omitted ``$uri`` or passed ``null`` already failed with
 ``Call to a member function getHost() on null``, so it needs no migration.
 
+RedirectException Default Status Code
+======================================
+
+``CodeIgniter\HTTP\Exceptions\RedirectException`` no longer redeclares the inherited ``$code`` property to store the status applied to a
+``Response`` whose status is outside the 301-308 range. If you have a subclass that overrode ``$code`` for this purpose, override the new
+``$defaultStatusCode`` property instead:
+
+.. code-block:: php
+
+    // Before
+    class MyRedirectException extends RedirectException
+    {
+        protected $code = 307;
+    }
+
+    // After
+    class MyRedirectException extends RedirectException
+    {
+        protected int $defaultStatusCode = 307;
+    }
+
 *********************
 Breaking Enhancements
 *********************

utils/phpstan-baseline/loader.neon

@@ -1,4 +1,4 @@
-# total 689 errors
+# total 688 errors
 
 includes:
     - argument.type.neon

utils/phpstan-baseline/property.phpDocType.neon

@@ -1,4 +1,4 @@
-# total 21 errors
+# total 20 errors
 
 parameters:
     ignoreErrors:
@@ -72,11 +72,6 @@ parameters:
             count: 1
             path: ../../system/Exceptions/PageNotFoundException.php
 
-        -
-            message: '#^PHPDoc type CodeIgniter\\HTTP\\URI of property CodeIgniter\\HTTP\\IncomingRequest\:\:\$uri is not the same as PHPDoc type CodeIgniter\\HTTP\\URI\|null of overridden property CodeIgniter\\HTTP\\OutgoingRequest\:\:\$uri\.$#'
-            count: 1
-            path: ../../system/HTTP/IncomingRequest.php
-
         -
             message: '#^PHPDoc type string of property CodeIgniter\\Session\\Handlers\\FileHandler\:\:\$savePath is not the same as PHPDoc type array\<string, mixed\>\|string of overridden property CodeIgniter\\Session\\Handlers\\BaseHandler\:\:\$savePath\.$#'
             count: 1