Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: PHPStan Codeigniter no type specified #7948

Merged
merged 2 commits into from
Sep 19, 2023
Merged

docs: PHPStan Codeigniter no type specified #7948

merged 2 commits into from
Sep 19, 2023

Conversation

ddevsr
Copy link
Collaborator

@ddevsr ddevsr commented Sep 16, 2023

Description
See #7731
Supersedes #7884

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@ddevsr ddevsr added the documentation Pull requests for documentation only label Sep 16, 2023
@kenjis kenjis added the stale Pull requests with conflicts label Sep 18, 2023
@kenjis
Copy link
Member

kenjis commented Sep 18, 2023

label-confilct does not work?

@ddevsr ddevsr added stale Pull requests with conflicts and removed stale Pull requests with conflicts labels Sep 18, 2023
@ddevsr ddevsr added stale Pull requests with conflicts and removed stale Pull requests with conflicts labels Sep 18, 2023
@ddevsr
Copy link
Collaborator Author

ddevsr commented Sep 18, 2023

Still job PullRequests: read

https://github.com/codeigniter4/CodeIgniter4/actions/runs/6220393970/job/16880333917?pr=7948

@ddevsr ddevsr removed the stale Pull requests with conflicts label Sep 18, 2023
@kenjis kenjis merged commit f0af89d into codeigniter4:develop Sep 19, 2023
@ddevsr ddevsr deleted the codeigniter-specified-type branch September 19, 2023 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis approved these changes

Assignees
No one assigned
Labels
documentation Pull requests for documentation only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ddevsr @kenjis