Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Fix phpstan method.impossibleType #9384

Conversation

neznaika0
Copy link
Contributor

Description
I have updated the tests so that they change the object. It's so easy to track event triggers instead of bool checks.

Fixed the message at the same time: Call to an undefined method Events::unInitialize()

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@neznaika0 neznaika0 force-pushed the refactor/phpstan-method-impossibleType branch from 7ceb6fd to 68d8f1d Compare January 8, 2025 17:13
@neznaika0 neznaika0 changed the base branch from 4.6 to develop January 8, 2025 17:13
@neznaika0 neznaika0 force-pushed the refactor/phpstan-method-impossibleType branch from 68d8f1d to b44901c Compare January 8, 2025 17:15
@neznaika0
Copy link
Contributor Author

It's not that easy to rebase branches

@paulbalandan
Copy link
Member

You can refer to here if you are switching the base branch. The git rebase --onto is a life-saver.

@neznaika0
Copy link
Contributor Author

Thanks, I'll try. Before that, I used cherry-pick and reset --hard

@samsonasik
Copy link
Member

@neznaika0 I wrote a blog post about rebase as well FYI https://samsonasik.wordpress.com/2015/09/16/practical-git-4-rebasing-conflicted-task-branch-against-primary-branch/

@paulbalandan paulbalandan added the testing Pull requests that changes tests only label Jan 10, 2025
@paulbalandan paulbalandan merged commit e3a139d into codeigniter4:develop Jan 10, 2025
39 checks passed
@neznaika0 neznaika0 deleted the refactor/phpstan-method-impossibleType branch January 10, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Pull requests that changes tests only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants