fix: Logger - allow variable {line} to be used without variable {file} when logging message #9502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neznaika0
suggested changes
Apr 3, 2025
|
|
||
| $logs = TestHandler::getLogs(); | ||
|
|
||
| $this->assertGreaterThan(1, strpos($logs[0], $expected)); |
There was a problem hiding this comment.
No?
Suggested change
| $this->assertGreaterThan(1, strpos($logs[0], $expected)); | |
| $this->assertTrue(str_contains($logs[0], $expected)); |
There was a problem hiding this comment.
Yes, we can also write it this way, but I wanted to use the same style as in the previous test. This will ensure that the correct text is added to the log message. The logged message should not start with the $expected string.
paulbalandan
approved these changes
Apr 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where the
{line}variable in the Logger cannot be used without specifying the{file}variable in the logged message.Fixes #9501
Checklist: