-
Notifications
You must be signed in to change notification settings - Fork 1
Feat/89 알림 컴포넌트 구현 #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/89 알림 컴포넌트 구현 #116
Conversation
|
Warning Rate limit exceeded@minimo-9 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 7 minutes and 1 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (14)
Walkthrough알림 기능이 대폭 추가 및 개선되었습니다. 신규 알림 API 라우트와 관련 커스텀 훅, 타입, 유틸 함수, 그리고 알림 드롭다운 및 카드 UI 컴포넌트가 도입되었습니다. 로그인/회원가입/로딩 컴포넌트의 마진 및 레이아웃도 일부 수정되었습니다. Header 컴포넌트는 알림 드롭다운 연동과 비동기 로그아웃 처리로 업데이트되었습니다. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Header
participant NotificationDropdown
participant NotificationCardList
participant API as /api/my-notifications
participant useNotification
User->>Header: 알림 아이콘 클릭
Header->>NotificationDropdown: 드롭다운 열기
NotificationDropdown->>useNotification: 알림 목록 fetch
useNotification->>API: GET /api/my-notifications
API-->>useNotification: 알림 데이터 반환
useNotification-->>NotificationDropdown: 알림 데이터 전달
NotificationDropdown->>NotificationCardList: 알림 목록 렌더링
User->>NotificationDropdown: 닫기 버튼 클릭
NotificationDropdown->>Header: onClose 콜백 실행
sequenceDiagram
participant User
participant NotificationCard
participant useDeleteNotification
participant API as /api/my-notifications/[notificationId]
User->>NotificationCard: 삭제 버튼 클릭
NotificationCard->>useDeleteNotification: mutate(notificationId)
useDeleteNotification->>API: DELETE /api/my-notifications/[notificationId]
API-->>useDeleteNotification: 204 No Content
useDeleteNotification-->>NotificationCard: onSuccess (알림 리스트 갱신)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~15–20 minutes Suggested reviewers
Poem
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
LeeCh0129
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다~
|
로직과 디바이스별로 반응형 디자인까지 구현하시는데 수고많으셨습니다! |
📌 변경 사항 개요
알림 컴포넌트 구현, 헤더에 알림 추가, 로그아웃 기능 수정
📝 상세 내용
체험 예약을 승인, 거절 시 나오는 알림창 구현
실시간 처럼 보이기 위해 10초마다 자동으로 api를 불러옴
로그아웃에 토큰이 안 지워지던 부분을 수정
🔗 관련 이슈
🖼️ 스크린샷(선택사항)
데스크탑, 태블릿


모바일
💡 참고 사항
Summary by CodeRabbit
신규 기능
버그 수정/스타일
문서화 및 타입