-
Notifications
You must be signed in to change notification settings - Fork 1
Feat/64 체험 상세페이지 전체 레이아웃 1차완성 #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| import React from 'react'; | ||
|
|
||
| const Star = ({ size = 20, color = '#fff', ...props }) => ( | ||
| <svg | ||
| xmlns='http://www.w3.org/2000/svg' | ||
| width={size} | ||
| height={size} | ||
| viewBox='0 0 20 20' | ||
| fill={color} | ||
| {...props} | ||
| > | ||
| <path | ||
| d='M12.3122 15.0005C12.2069 15.0009 12.1042 14.9681 12.0187 14.9067L7.99966 11.993L3.9806 14.9067C3.89474 14.969 3.79129 15.0024 3.68522 15.002C3.57915 15.0016 3.47595 14.9675 3.39054 14.9046C3.30513 14.8417 3.24193 14.7532 3.21009 14.6521C3.17825 14.5509 3.17942 14.4422 3.21341 14.3417L4.78091 9.69891L0.718413 6.91298C0.630416 6.8527 0.564002 6.76586 0.528872 6.66515C0.493743 6.56444 0.491741 6.45513 0.523158 6.3532C0.554575 6.25127 0.617764 6.16206 0.703494 6.0986C0.789224 6.03514 0.893001 6.00076 0.999663 6.00048H6.01154L7.52404 1.34579C7.55662 1.2453 7.6202 1.15771 7.70564 1.09558C7.79109 1.03346 7.89402 1 7.99966 1C8.10531 1 8.20823 1.03346 8.29368 1.09558C8.37913 1.15771 8.44271 1.2453 8.47529 1.34579L9.98779 6.00204H14.9997C15.1065 6.00199 15.2105 6.03613 15.2964 6.09947C15.3824 6.16281 15.4459 6.25201 15.4775 6.35402C15.5091 6.45603 15.5072 6.56548 15.4721 6.66634C15.437 6.76721 15.3706 6.85419 15.2825 6.91454L11.2184 9.69891L12.785 14.3405C12.8104 14.4156 12.8175 14.4957 12.8058 14.5742C12.7941 14.6526 12.7639 14.7272 12.7177 14.7917C12.6715 14.8561 12.6107 14.9087 12.5401 14.945C12.4696 14.9813 12.3915 15.0003 12.3122 15.0005Z' | ||
| fill='#FFC23D' | ||
| /> | ||
| </svg> | ||
| ); | ||
|
|
||
| export default Star; | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,10 +14,10 @@ export default function ReviewCard({ | |
| avatarSrc, | ||
| }: UserReviewProps) { | ||
| return ( | ||
| <div className='mx-auto flex max-w-md items-start gap-6 p-6 text-black md:max-w-2xl'> | ||
| <div className='flex max-w-md justify-start gap-6 p-6 text-black md:max-w-2xl'> | ||
| <Avatar src={avatarSrc} size='sm' /> | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion 파이프라인 오류를 수정해야 합니다. Avatar 컴포넌트의 props 정렬을 수정해야 합니다. - <Avatar src={avatarSrc} size='sm' />
+ <Avatar size='sm' src={avatarSrc} />🧰 Tools🪛 GitHub Actions: CI[warning] 18-18: Props should be sorted alphabetically (react/jsx-sort-props) 🤖 Prompt for AI Agents |
||
| <div className='grid flex-1 gap-6'> | ||
| <div className='flex items-center gap-10 text-sm md:text-lg'> | ||
| <div className='flex gap-10 text-sm md:text-lg'> | ||
| <p className='font-bold'>{userName}</p> | ||
| <p className='text-black'>|</p> | ||
| <p className='text-gray-600'>{date}</p> | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| import Star from '@assets/svg/star'; | ||
|
|
||
| export default function ReviewTitle() { | ||
| return ( | ||
| <div className='mt-10 mb-10 flex flex-col'> | ||
| <h2 className='text-2xl font-bold'>후기</h2> | ||
|
|
||
| <div className='mt-15 flex items-center gap-15'> | ||
| <h2 className='text-4xl font-bold'>4.2</h2> | ||
| <div className='flex flex-col gap-10'> | ||
| <p>매우 만족</p> | ||
| <div className='flex items-center'> | ||
| <Star /> | ||
| <p>1300개 후기</p> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| ); | ||
| } |
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
| @@ -1,15 +1,28 @@ | ||||||||
| 'use client'; | ||||||||
|
|
||||||||
| import useBookingStore from '@/stores/Booking/useBookingStore'; | ||||||||
| import IconClose from '@assets/svg/close'; | ||||||||
| import DatePicker from '../DatePicker/DatePicker'; | ||||||||
| import TimeSelector from './TimeSelector'; | ||||||||
|
|
||||||||
| export default function TabletPopup({}) { | ||||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 불필요한 빈 객체 패턴을 제거하세요. 정적 분석 도구에서 빈 객체 패턴에 대한 오류가 발생했습니다. props가 필요하지 않다면 매개변수를 제거하세요. -export default function TabletPopup({}) {
+export default function TabletPopup() {📝 Committable suggestion
Suggested change
🧰 Tools🪛 Biome (1.9.4)[error] 8-8: Unexpected empty object pattern. (lint/correctness/noEmptyPattern) 🤖 Prompt for AI Agents |
||||||||
| const isOpen = useBookingStore((state) => state.isOpen); | ||||||||
| const setIsOpen = useBookingStore((state) => state.setIsOpen); | ||||||||
|
|
||||||||
| if (!isOpen) return null; | ||||||||
|
|
||||||||
| export default function TabletPopup() { | ||||||||
| return ( | ||||||||
| <div className='flex items-center justify-center'> | ||||||||
| <div | ||||||||
| className={ | ||||||||
| 'relative m-auto flex h-fit max-h-[85%] w-screen min-w-[375] flex-col bg-white p-8 px-10 shadow-2xl inset-shadow-sm inset-shadow-gray-300 md:h-fit md:w-[50%] md:max-w-600' | ||||||||
| } | ||||||||
| > | ||||||||
| <DatePicker /> | ||||||||
| <div className='absolute z-50 flex flex-col items-center justify-center'> | ||||||||
| <div className='flex justify-between'> | ||||||||
| <h2>날짜</h2> | ||||||||
| <button onClick={() => setIsOpen(false)}> | ||||||||
| <IconClose /> | ||||||||
| </button> | ||||||||
| </div> | ||||||||
|
|
||||||||
| <DatePicker /> | ||||||||
|
|
||||||||
| <TimeSelector /> | ||||||||
| </div> | ||||||||
| ); | ||||||||
| } | ||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
color prop의 기본값과 실제 사용이 일치하지 않습니다.
color prop의 기본값은
#fff이지만 path 요소에서는 항상#FFC23D가 사용됩니다. 이는 혼란을 야기할 수 있습니다.다음 중 하나를 선택하여 수정하세요:
옵션 1: path에서 color prop 사용
<path d='M12.3122 15.0005C12.2069 15.0009 12.1042 14.9681 12.0187 14.9067L7.99966 11.993L3.9806 14.9067C3.89474 14.969 3.79129 15.0024 3.68522 15.002C3.57915 15.0016 3.47595 14.9675 3.39054 14.9046C3.30513 14.8417 3.24193 14.7532 3.21009 14.6521C3.17825 14.5509 3.17942 14.4422 3.21341 14.3417L4.78091 9.69891L0.718413 6.91298C0.630416 6.8527 0.564002 6.76586 0.528872 6.66515C0.493743 6.56444 0.491741 6.45513 0.523158 6.3532C0.554575 6.25127 0.617764 6.16206 0.703494 6.0986C0.789224 6.03514 0.893001 6.00076 0.999663 6.00048H6.01154L7.52404 1.34579C7.55662 1.2453 7.6202 1.15771 7.70564 1.09558C7.79109 1.03346 7.89402 1 7.99966 1C8.10531 1 8.20823 1.03346 8.29368 1.09558C8.37913 1.15771 8.44271 1.2453 8.47529 1.34579L9.98779 6.00204H14.9997C15.1065 6.00199 15.2105 6.03613 15.2964 6.09947C15.3824 6.16281 15.4459 6.25201 15.4775 6.35402C15.5091 6.45603 15.5072 6.56548 15.4721 6.66634C15.437 6.76721 15.3706 6.85419 15.2825 6.91454L11.2184 9.69891L12.785 14.3405C12.8104 14.4156 12.8175 14.4957 12.8058 14.5742C12.7941 14.6526 12.7639 14.7272 12.7177 14.7917C12.6715 14.8561 12.6107 14.9087 12.5401 14.945C12.4696 14.9813 12.3915 15.0003 12.3122 15.0005Z' - fill='#FFC23D' + fill={color} />옵션 2: color prop 기본값을 실제 사용 색상으로 변경
Also applies to: 14-14
🤖 Prompt for AI Agents
🛠️ Refactor suggestion
TypeScript 인터페이스를 추가해야 합니다.
props에 대한 타입 정의가 누락되어 타입 안전성이 보장되지 않습니다.
다음과 같이 인터페이스를 추가하세요:
📝 Committable suggestion
🤖 Prompt for AI Agents