๐ fix: DropdownProps๋ฅผ ์ ๋ค๋ฆญ ํ์ ์ผ๋ก ๋ณ๊ฒฝ #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minimo-9
added
the
๐ ๋ฒ๊ทธ ์์
1 task
Moon-ju-young
approved these changes
Jun 18, 2025
src/components/common/Dropdown.tsx
Outdated
Comment on lines
10
to
24
| interface DropdownProps<OptionType extends string> { | ||
| options: readonly OptionType[]; | ||
| selected: OptionType; | ||
| setSelect: Dispatch<SetStateAction<OptionType>>; // Dispatch<SetStateAction<string>>๋ setํจ์ ํ์ | ||
| placeholder?: string; | ||
| variant: 'form' | 'filter'; | ||
| } | ||
|
|
||
| export default function Dropdown({ | ||
| export default function Dropdown<OptionType extends string>({ | ||
| options, | ||
| selected, | ||
| setSelect, | ||
| placeholder = '์ ํ', | ||
| variant, | ||
| }: DropdownProps) { | ||
| }: DropdownProps<OptionType>) { |
Contributor
There was a problem hiding this comment.
๐ฌ generic type์ด๋ผ๋ฉด ๊ทธ๋ฅ OptionType ๋ง๊ณ ๊ฐ๋จํ๊ฒ T๋ผ๊ณ ์ ์ด๋ ๋์ง ์๋ ์ถ๋ค์!
Collaborator
Author
There was a problem hiding this comment.
์ ์๋ T๋ก ํ๋ ค๊ณ ํ๋๋ฐ ์ข ๋ ์์๋ณด๊ธฐ ์ข๊ฒ ์ต์ ์ผ๋ก ๋ฃ์์ต๋๋ค!
Collaborator
Author
There was a problem hiding this comment.
๋ณ๊ฒฝํ๊ฒ ์ต๋๋ค!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐ ๋ณ๊ฒฝ ์ฌํญ ๊ฐ์
DropdownProps๋ฅผ ์ ๋ค๋ฆญ ํ์ ์ผ๋ก ๋ณ๊ฒฝ
๐ ์์ธ ๋ด์ฉ
๋๋กญ๋ค์ด ์์๋ฅผ ํ์ ์ผ๋ก ๋ณ๊ฒฝํจ์ผ๋ก์ ๊ธฐ์กด ๋๋กญ๋ค์ด์ ํ์ ์ด string์ผ๋ก ๋์ด ์ค๋ฅ๊ฐ ๋๋ ๋ถ๋ถ์ ์ ๋ค๋ฆญ ํ์ ์ผ๋ก ๋ณ๊ฒฝํ์ฌ ์ค๋ฅ ์ํ
๐ ๊ด๋ จ ์ด์
๐ผ๏ธ ์คํฌ๋ฆฐ์ท(์ ํ์ฌํญ)
๐ก ์ฐธ๊ณ ์ฌํญ