♻️ refactor: ApplicationStatus type 분리 #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
minimo-9
approved these changes
Jun 18, 2025
Yun-Jinwoo
approved these changes
Jun 18, 2025
Collaborator
Yun-Jinwoo
left a comment
Yun-Jinwoo
left a comment
There was a problem hiding this comment.
고생하셨습니다!
이번처럼 분리가 필요하다고 느끼는 시점이 오면 그때 분리하면 되지 않을까 싶네요~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 변경 사항 개요
ApplicationStatus type(
'pending' | 'accepted' | 'rejected' | 'canceled') 분리📝 상세 내용
'pending' | 'accepted' | 'rejected' | 'canceled'이 외부에서 쓰이는 데가 있어 오타 및 오류 방지로 type을 분리하였습니다.🔗 관련 이슈
Resolves: #108
🖼️ 스크린샷(선택사항)
💡 참고 사항
Exclude<ApplicationStatus, 'pending'>('accepted' | 'rejected' | 'canceled') type도 분리할까 하다가 따로 분리는 안했습니다. 분리가 필요한 거 같다 하시면 의견 부탁드립니다~