✨ feat: notice API 함수 구현 및 type 리팩토링 #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 변경 사항 개요
noticeApi파일의 type들을 리팩토링하였습니다.📝 상세 내용
getNotices: GET/notices함수getShopNotices: GET/shops/{shop_id}/notices함수postShopNotice: POST/shops/{shop_id}/notices함수getShopNotice: GET/shops/{shop_id}/notices/{notice_id}함수putShopNotice: PUT/shops/{shop_id}/notices/{notice_id}함수🔗 관련 이슈
Resolves: #76
🖼️ 스크린샷(선택사항)
💡 참고 사항
getNotices>getTotalNotices이런 식으로 바꿀까 생각도 했는데 일단은 최대한 api url과 비슷하게 두었습니다.putShopNotice의 마감된 공고는 수정할 수 없습니다 빼고 일단 동작하는 것을 테스트 완료했습니다.