-
Notifications
You must be signed in to change notification settings - Fork 1
✨ feat: 공고리스트 구현 #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ feat: 공고리스트 구현 #123
Changes from 5 commits
b125c62
777d17c
8cb405f
d30fbed
9f2fc0a
a4af561
253dca9
edfd48e
22362fa
9885d5b
3398663
be8360c
502f8b5
5d1cf6f
615b800
6f6cbe0
290b56d
95bd39f
ed7fb18
0c7674d
8d427fa
9d591bb
af96c14
3295a85
50a4750
0473cb1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Moon-ju-young marked this conversation as resolved.
Show resolved
Hide resolved
|
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,3 +1,204 @@ | ||||||||||||||||||
| export default function NoticeList() { | ||||||||||||||||||
| return <div>공고 리스트</div>; | ||||||||||||||||||
| import { useEffect, useState } from 'react'; | ||||||||||||||||||
| import Post from '@/components/common/Post'; | ||||||||||||||||||
| import Dropdown from '@/components/common/Dropdown'; | ||||||||||||||||||
| import { SORT_OPTIONS } from '@/constants/dropdownOptions'; | ||||||||||||||||||
| import Pagination from '@/components/common/Pagination'; | ||||||||||||||||||
| import Filter from '@/components/common/Filter'; | ||||||||||||||||||
| import { getNotices } from '@/api/noticeApi'; | ||||||||||||||||||
| import type { NoticeWithShopItem } from '@/api/noticeApi'; | ||||||||||||||||||
| import { Link } from 'react-router-dom'; | ||||||||||||||||||
|
|
||||||||||||||||||
| type FilterValues = { | ||||||||||||||||||
| address?: string[] | null; | ||||||||||||||||||
| startsAt?: string | null; | ||||||||||||||||||
| hourlyPay?: number | null; | ||||||||||||||||||
| }; | ||||||||||||||||||
|
|
||||||||||||||||||
| type NoticeListProps = { | ||||||||||||||||||
| search?: string; | ||||||||||||||||||
| }; | ||||||||||||||||||
|
||||||||||||||||||
|
|
||||||||||||||||||
| // ===================== 상수 ===================== | ||||||||||||||||||
|
||||||||||||||||||
| // ===================== 상수 ===================== | |
| // 상수 |
💬 그냥 간단하게 주석을 적어주셔도 될 것 같습니다~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵 이건 수정했습니다
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💬 어디 부분은 generic을 사용하고 어느 부분은 사용하고 있지 않네요~ 기본형 들은 generic을 빼고 자동으로 추론되게 해도 괜찮을 것 같습니다~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요부분은 제가 지워 놓겠습니다
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ 이렇게 된다면 null 병합 연산자 (??)를 쓰는 의미가 없지 않나요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수정했습니다!
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💬 현재 전체적으로 error 처리는 try ~ catch 문으로 하고 계신 거 같아서 try catch 문으로 바꿔주시면 좋을 것 같습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
변경하겠습니다
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❗ mobile 일 때는 padding 값이 다릅니다~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
네 알겠습니다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
디자인은 다시해서 변경 되었습니다!
Moon-ju-young marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| to={`/shops/${notice.shop.item.id}/notices/${notice.id}`} | |
| to={`/${notice.id}`} |
❗ 공고 상세 페이지의 주소는 그냥 /:id 입니다~ 프로젝트 정리 문서 참고하시면 좋을 것 같아요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
네 알겠습니다 감사합니다
Moon-ju-young marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <span className="text-h1 font-bold text-primary"> | |
| {search} | |
| </span> | |
| <span className="text-h1 font-bold">에 대한 공고 목록</span> | |
| <span className="text-primary"> | |
| {search} | |
| </span> | |
| 에 대한 공고 목록 |
💬 이런식으로도 작성 가능할 것 같습니다~ 기본적으로 font 설정들은 상속이 되기 때문에 상위 태그에서 지정해주면 하위에서는 설정하지 않을 수도 있습니다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
네 알겠습니다!
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| {appliedFilterCount > 0 && ( | |
| <span className="ml-2">({appliedFilterCount})</span> | |
| )} | |
| {appliedFilterCount > 0 && ( | |
| ' ' + appliedFilterCount | |
| )} |
💬 이런 식으로도 가능하지 않을까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
간결하고 더 좋네요 리펙토링때 수정하겠습니다!
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ 이미 페이지 구성은 정리된지라 구성을 변경하실 거라면 논의 후에 진행하셨으면 좋았을 것 같습니다~ 그리고 SearchPage 없이 구현이 가능할 것 같은데 어렵나요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
네 알겠습니다 merge이후에 리펙토링때 수정해놓겠습니다