✨ feat: 알림 모달창 구현 #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
Contributor
Moon-ju-young
left a comment
Moon-ju-young
left a comment
There was a problem hiding this comment.
저희 jsDoc 사용하기로 합의했나요?
minimo-9
approved these changes
Jun 8, 2025
| } else if (months <= 11) { | ||
| return `${months}달 전`; | ||
| } else { | ||
| return `${years}년 전`; |
Collaborator
Author
음 따로 정하지는 않았는데, 이게 뭐 라이브러리나 패키지가 아니라 그냥 주석 형식의 일종이다보니, 멘토님 말씀대로 주석을 좀 더 자세히 작성하기 위해 이런 형식으로 사용했습니다~! |
Moon-ju-young
approved these changes
Jun 8, 2025
Contributor
Moon-ju-young
left a comment
Moon-ju-young
left a comment
There was a problem hiding this comment.
확인했습니다 jsDoc 같은 경우 일반 주석과는 달리 쓰냐마냐에 따라 파일 스타일이 많이 달라지는 거 같아서 멘토님이 말하시는 한 사람이 쓴 거 같은 코드를 지향한다면 팀적으로 쓸지 말지 정하는 게 좋을 것 같습니다~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 변경 사항 개요
📝 상세 내용
알림 모달창 구현 -
NotificationModal알림 모달창 내 카드 구현 -
NotificationCardformatWorkTime함수 활용)calculateTimeDifference함수 활용)모달창 내에서 스크롤바 숨기기
tailwind-scrollbar-hide패키지 추가추후 구현 예정 기능
🔗 관련 이슈
🖼️ 스크린샷(선택사항)
PC, Tablet용 모달창
Mobile용 모달창
💡 참고 사항
부족한 부분이 있으면 말씀해주시면 감사하겠습니다 (_ _)