-
Notifications
You must be signed in to change notification settings - Fork 1
✨ feat: Button Component 구현 #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- border-radius 속성 추가
Closed
2 tasks
minimo-9
reviewed
Jun 9, 2025
Collaborator
minimo-9
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
코드가 굉장히 간결하고 필요한 기능만 있는 것 같아서 굉장히 잘 만드셨네요!
minimo-9
approved these changes
Jun 10, 2025
Yun-Jinwoo
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 변경 사항 개요
button component를 만들었습니다.
📝 상세 내용
solidprop은 Boolean 타입으로 button의 스타일을 결정합니다.sizeprop은 button의 크기를 결정합니다.--color-primary변수를 추가하였습니다.🔗 관련 이슈
Resolves: #11
🖼️ 스크린샷(선택사항)
width를 설정하지 않아 좁게 보입니다
💡 참고 사항