-
Notifications
You must be signed in to change notification settings - Fork 4
✨ Feat: 프레임 컴포넌트 구현 #1 #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| const Footer = () => { | ||
| return <div>footer</div>; | ||
| }; | ||
|
|
||
| export default Footer; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| import { useRouter } from 'next/router'; | ||
|
|
||
| interface FrameProps { | ||
| title: string; | ||
| content: string; | ||
| buttonText: string; | ||
| address: string; | ||
| } | ||
|
|
||
| const Frame = ({ title, content, buttonText, address }: FrameProps) => { | ||
| const router = useRouter(); | ||
| return ( | ||
| <> | ||
| <section className='flex flex-col gap-4 px-3 py-10 tablet:px-8 tablet:py-[60px] desktop:px-[237px] desktop:py-[60px]'> | ||
| <h1 className='text-xl font-bold text-black tablet:text-[28px]'>{title}</h1> | ||
| <div className='flex flex-col items-center justify-center gap-4 rounded-xl border border-solid border-gray-200 px-6 py-[60px]'> | ||
| <h2 className='text-sm font-normal text-black tablet:text-base'>{content}</h2> | ||
| <button | ||
| onClick={() => router.push(`/${address}`)} | ||
| className='rounded-md bg-[#ea3c12] px-5 py-[10px] text-sm font-bold text-white tablet:px-[136px] tablet:py-[14px] tablet:text-base' | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 버튼 스타일은 추후 신천님께서 버튼 컴포넌트 제작하면 리팩토링 하셔도 좋을것 같습니다. |
||
| > | ||
| {buttonText} | ||
| </button> | ||
| </div> | ||
| </section> | ||
| </> | ||
| ); | ||
| }; | ||
|
|
||
| export default Frame; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
어느 페이지로 이동하는거면 Next 컴포넌트의 Link 를 사용하는것도 좋은 방법일것 같습니다.
또한 네이밍도 address 는 일반 주소를 의미하는 뜻이 강해 navigate / route / href 와 같은 패스형태의 네이밍도 추천드립니다 :)