[나지원] sprint10 #128
Merged
[나지원] sprint10 #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GANGYIKIM
approved these changes
Nov 5, 2024
| } | ||
|
|
||
| const AuthorInfo = ({ className, nickname, image, date }: Props) => { | ||
| const AuthorInfo = ({ nickname, date, className, image }: Props) => { |
Collaborator
There was a problem hiding this comment.
P3:
Suggested change
| const AuthorInfo = ({ nickname, date, className, image }: Props) => { | |
| const AuthorInfo = ({ nickname, date, className ='' , image }: Props) => { |
Comment on lines
+25
to
+26
| const allowedTypes = ["image/png", "image/jpeg"]; | ||
| if (!allowedTypes.includes(nextValue.type)) return; |
Collaborator
There was a problem hiding this comment.
사용자 피드백까지 주면 더 좋을 것 같아요~
Comment on lines
+10
to
+16
| const HeartButton = ({ favoriteCount, className }: HeartButtonProps) => { | ||
| return ( | ||
| <button | ||
| type="button" | ||
| aria-label="좋아요 버튼" | ||
| className={`${styles.heartButton} ${className}`} | ||
| > |
Collaborator
There was a problem hiding this comment.
P3:
아직 필요하지 않으셔서 추가하지 않은 것 같지만 버튼이니 나중에 onClick 함수를 넘길 수 있게 추가해주세요~
| }, [refreshAccessToken]); | ||
|
|
||
| return ( | ||
| <AuthContext.Provider value={{ accessToken, login, logout }}> |
Collaborator
There was a problem hiding this comment.
P2:
멘토링때 말씀드린것처럼 context 사용시 전달되는 value는 자식들의 잦은 리렌더링을 막기위해 useMemo를 감싸 전달합니다.
관련해서 읽으실만한 글 링크드립니다~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
상품 등록 페이지
상품 상세 페이지
심화
스크린샷
배포 페이지: https://najimarket.vercel.app/boards
상품 등록 페이지
상품 상세 페이지
멘토에게