[김주동] sprint11 #131
Merged
[김주동] sprint11 #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
React 김주동 sprint6
* First commit Sprint Mission5 on React * Sprint mission 6 commit. * Sprint Mission 6 Update 1 * update sprint mission 6 * Sprint mission 6 update commit. * delete .bak files * Update Comments * modify ItemComment
…print-Mission into Next-김주동-sprint9
GANGYIKIM
approved these changes
Nov 11, 2024
Collaborator
GANGYIKIM
left a comment
GANGYIKIM
left a comment
There was a problem hiding this comment.
주동님 이번 스프린트 미션 고생하셨습니다~
불필요한 주석이 많아서 다음에는 정리후 PR 올려주시면 더 좋을 것 같아요!
시간이 되시면 리팩토링을 통해 코드정리를 해보시면 더 좋을 것 같습니다~
Comment on lines
+8
to
+10
| headers: { | ||
| "Content-Type": "application/json", | ||
| }, |
Collaborator
There was a problem hiding this comment.
P3:
header content-type 에 대한 mdn 문서입니다~
전송되는 데이터 타입에 대해 명시해주는 값입니다.
https://developer.mozilla.org/ko/docs/Web/HTTP/Headers/Content-Type
| "react": "^18", | ||
| "react-dom": "^18", | ||
| "react-hook-form": "^7.53.1", | ||
| "react-router-dom": "^6.28.0", |
Collaborator
There was a problem hiding this comment.
P3:
next가 깔려있으니 next를 사용하시면 더 좋겠습니다~
| id: string; | ||
| label: string; | ||
| placeholder: string; | ||
| register: UseFormRegisterReturn; // react-hook-form의 register 함수 사용 |
Collaborator
There was a problem hiding this comment.
P2:
register이라는 명은 꼭.. react-hook-form의 register 함수 자체를 의미하는 것 같습니다.
더 적절한 이름이면 좋을 것 같아요.
| register, | ||
| errorMessage, | ||
| }) => { | ||
| const [showPassword, setShowPassword] = useState(false); |
Collaborator
There was a problem hiding this comment.
P3:
boolean 값에서 이름은 isShowPassword가 더 일반적일 것 같습니다~
| formState: { errors, isValid }, | ||
| } = useForm<LoginFormValues>({ mode: "onChange" }); | ||
|
|
||
| const onSubmit: SubmitHandler<LoginFormValues> = async (data) => { |
Collaborator
There was a problem hiding this comment.
P2:
data 자체로 사용하지 않으니 아래처럼 분해해서 쓰시는게 더 좋을 것 같습니다.
Suggested change
| const onSubmit: SubmitHandler<LoginFormValues> = async (data) => { | |
| const onSubmit: SubmitHandler<LoginFormValues> = async ({ email, password }) => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
주요 변경사항
스크린샷
멘토에게