[이수지] sprint11 #132
Merged
[이수지] sprint11 #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 7, 2024 15:18
React의 18버전에서 `fetchPriority` prop이 DOM 요소에서 인식되지 않는 버그로 인함
GANGYIKIM
approved these changes
Nov 11, 2024
Collaborator
GANGYIKIM
left a comment
GANGYIKIM
left a comment
There was a problem hiding this comment.
수지님 이번 스프린트 미션 수고하셨습니다~
| {/* 참고: 더보기 버튼 기능은 추후 요구사항에 따라 추가 예정 */} | ||
| <SeeMoreButton> | ||
| <SeeMoreIcon /> | ||
| {/* <SeeMoreIcon /> */} |
| { | ||
| headers: { | ||
| 'Content-Type': 'multipart/form-data', | ||
| Authorization: `Bearer ${process.env.NEXT_PUBLIC_API_TOKEN}`, |
Collaborator
There was a problem hiding this comment.
P3:
axios를 사용하시니 interceptor 기능을 이용해 요청을 보내기전에 토큰을 넣어주는 방식으로 개발하시면 코드 반복도 줄이고 더 좋을 것 같습니다~
https://axios-http.com/docs/interceptors
https://velog.io/@horang-e/Axios-Interceptor%EB%A1%9C-accessToken%EA%B0%B1%EC%8B%A0%ED%95%98%EA%B8%B0-RefreshToken
| encodeFileToBase64(selectedFile); | ||
| } | ||
| }; | ||
| const { previewImageSrc, handleImagePreview, uploadImage, imageFile } = |
Collaborator
There was a problem hiding this comment.
P3:
hook으로 분리하신거 좋습니다 👍
| import IconEyeVisible from '@/public/images/icons/eye-visible.svg'; | ||
| import Logo from '@/public/images/logo/logo.svg'; | ||
|
|
||
| function LoginPage(): React.ReactElement { |
Collaborator
There was a problem hiding this comment.
P2:
items/[id] 페이지는 화살표함수로 선언하시고 해당 페이지는 함수 선언식으로 작성하셨네요~
같은 page 컴포넌트이므로 한가지 방식으로 통일하시면 좋겠습니다.
| e.preventDefault(); | ||
|
|
||
| try { | ||
| const res = await axios.post( |
Collaborator
There was a problem hiding this comment.
P2:
응답값이 any로 추론되니 어떤 값이 올지 명시해주시면 더 좋을 것 같습니다
Suggested change
| const res = await axios.post( | |
| const res = await axios.post<{accessToken: string; refreshToken: string;}>( |
| import IconEyeVisible from '@/public/images/icons/eye-visible.svg'; | ||
| import Logo from '@/public/images/logo/logo.svg'; | ||
|
|
||
| function LoginPage(): React.ReactElement { |
Collaborator
There was a problem hiding this comment.
P3:
useUploadImage 함수처럼 로그인 관련 로직들도 분리하면 가독성이 더 좋아질 것 같아요~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
회원가입
로그인
메인
심화
주요 변경사항
스크린샷
멘토에게