[이준희] Sprint8 #255
Merged
[이준희] Sprint8 #255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ithub-actions [Fix] delete merged branch github action
…sprint2 [이준희] Sprint2
…-sprint3 [이준희] Sprint3
…-sprint7 [이준희] Sprint7
Collaborator
|
수고 하셨습니다 ! 스프리트 미션 하시느라 정말 수고 많으셨어요. |
kiJu2
approved these changes
Nov 18, 2024
| }; | ||
|
|
||
| function AllItems() { | ||
| const [orderBy, setOrderBy] = useState<string>("recent"); |
Collaborator
There was a problem hiding this comment.
타입 범위를 좁혀볼까요 ?
Suggested change
| const [orderBy, setOrderBy] = useState<string>("recent"); | |
| const [orderBy, setOrderBy] = useState<"recent" | "like">("recent"); |
위와 같이 유니온 타입으로 설정한다면 더욱 명확한 타입을 전달할 수 있어요 !
Comment on lines
+7
to
+9
| interface BestItemCardProps { | ||
| item: Product; | ||
| } |
Collaborator
There was a problem hiding this comment.
(제안) 컴포넌트에서 사용되는 타입들만 선언해볼 수 있어요 !
Suggested change
| interface BestItemCardProps { | |
| item: Product; | |
| } | |
| interface BestItemCardProps { | |
| id: number; | |
| name: string; | |
| price: number; | |
| description?: string; | |
| images: string[]; | |
| favoriteCount?: number; | |
| } |
function BestItemCard({ id, name, price ... }: BestItemCardProps) {
Collaborator
There was a problem hiding this comment.
그리고 호출부에서는 다음과 같이 사용할 수 있어요 !
<BestItemCard {...product} />
Comment on lines
+11
to
+15
| function BestItemCard({ item }: BestItemCardProps) { | ||
| return ( | ||
| <div className="item-card"> | ||
| <Link to={`/items/${item.id}`}> | ||
| <img src={item.images[0]} alt={item.name} className="item-card-img" /> |
Collaborator
There was a problem hiding this comment.
아니면 구조분해 할당을 사용해볼 수 있습니다 ! 😊
Suggested change
| function BestItemCard({ item }: BestItemCardProps) { | |
| return ( | |
| <div className="item-card"> | |
| <Link to={`/items/${item.id}`}> | |
| <img src={item.images[0]} alt={item.name} className="item-card-img" /> | |
| function BestItemCard({ item }: BestItemCardProps) { | |
| const { id, name, images } = item; | |
| return ( | |
| <div className="item-card"> | |
| <Link to={`/items/${item.id}`}> | |
| <img src={item.images[0]} alt={item.name} className="item-card-img" /> |
Comment on lines
+64
to
+65
| if (loading) return <div>댓글을 불러오는 중입니다...</div>; | ||
| if (error) return <div>{error}</div>; |
Comment on lines
+8
to
+18
| interface Comment { | ||
| id: number; | ||
| content: string; | ||
| createdAt: string; | ||
| updatedAt: string; | ||
| writer: { | ||
| id: number; | ||
| image: string; | ||
| nickname: string; | ||
| }; | ||
| } |
|
|
||
| function ItemComments() { | ||
| const { productId } = useParams<{ productId: string }>(); | ||
| const [comments, setComments] = useState<Comment[]>([]); |
Comment on lines
+11
to
+22
| interface ProductDetail { | ||
| id: number; | ||
| name: string; | ||
| description: string; | ||
| price: number; | ||
| createdAt: string; | ||
| favoriteCount: number; | ||
| ownerNickname: string; | ||
| ownerId: number; | ||
| images: string[]; | ||
| tags: string[]; | ||
| } |
Collaborator
There was a problem hiding this comment.
깔끔 -! 합니다 ㅎㅎㅎ 👍👍👍
벌써 적응 하셨군요 ㅎㅎㅎ
Comment on lines
+10
to
+19
| } | ||
|
|
||
| function Pagination({ | ||
| currentPage, | ||
| totalPageNum, | ||
| onPageChange, | ||
| }: PaginationProps) { | ||
| const pageNumbers = []; | ||
| const maxVisiblePages = 5; // 한 번에 표시할 최대 페이지 수 | ||
|
|
Collaborator
There was a problem hiding this comment.
컴포넌트 자원을 사용하지 않는다면 바깥으로 빼시는게 좋습니다 ! 😊
Suggested change
| } | |
| function Pagination({ | |
| currentPage, | |
| totalPageNum, | |
| onPageChange, | |
| }: PaginationProps) { | |
| const pageNumbers = []; | |
| const maxVisiblePages = 5; // 한 번에 표시할 최대 페이지 수 | |
| } | |
| const maxVisiblePages = 5; // 한 번에 표시할 최대 페이지 수 | |
| function Pagination({ | |
| currentPage, | |
| totalPageNum, | |
| onPageChange, | |
| }: PaginationProps) { | |
| const pageNumbers = []; | |
Comment on lines
+27
to
+31
| const response = await axios.post( | ||
| "https://panda-market-api.vercel.app/products", | ||
| formData | ||
| ); | ||
| const itemListResponse: ItemListResponse = response.data; |
Collaborator
There was a problem hiding this comment.
다음과 같이 axios에 제네릭을 사용할 수 있어요 ㅎㅎㅎ 😊
Suggested change
| const response = await axios.post( | |
| "https://panda-market-api.vercel.app/products", | |
| formData | |
| ); | |
| const itemListResponse: ItemListResponse = response.data; | |
| const response = await axios.post<ItemListResponse>( | |
| "https://panda-market-api.vercel.app/products", | |
| formData | |
| ); | |
| const itemListResponse = response.data; |
Comment on lines
+8
to
+18
| interface Comment { | ||
| id: number; | ||
| content: string; | ||
| createdAt: string; | ||
| updatedAt: string; | ||
| writer: { | ||
| id: number; | ||
| image: string; | ||
| nickname: string; | ||
| }; | ||
| } |
Collaborator
There was a problem hiding this comment.
지금 보니까 types.ts에 이미 정의되어있네요 ! 공통 타입을 import하는게 어떨까요 ?
Collaborator
|
수고하셨습니다 준희님 !! 타입스크립트 잘 적응하셨는데요 ?? 굳굳 👍 앞으로의 길 진심으로 승승장구하시길 바라겠습니다 !! 🙇♂️🙇♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
멘토에게