[오병훈] Sprint8 #257
Merged
[오병훈] Sprint8 #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
수고 하셨습니다 ! 스프리트 미션 하시느라 정말 수고 많으셨어요. |
kiJu2
approved these changes
Nov 18, 2024
|
|
||
| function AllItemsSection() { | ||
| const [orderBy, setOrderBy] = useState('recent'); | ||
| const [orderBy, setOrderBy] = useState<ProductOrderBy>('recent'); |
Collaborator
There was a problem hiding this comment.
크으 굳굳 ! 타입을 확인해보니 "recent" | "favorite"군요 !
명확한 타입입니다 ! 굳굳 ~! 👍
|
|
||
| function BestItemSection() { | ||
| const [itemList, setItemList] = useState([]); | ||
| const [itemList, setItemList] = useState<Product[]>([]); |
Collaborator
There was a problem hiding this comment.
굳굳 ! 여러 곳에서 사용될 타입을 정의함으로서 재사용성을 높였군요 ! 👍👍
Comment on lines
+6
to
+11
| interface FileInputProps { | ||
| name: string; | ||
| value: File | null; | ||
| initialPreview: string | null; | ||
| onChange: (name: string, value: File | null) => void; | ||
| } |
|
|
||
| const handleChange = (e) => { | ||
| const nextValue = e.target.files[0]; | ||
| const handleChange = (e: ChangeEvent<HTMLInputElement>) => { |
| function FileInput({ name, value, initialPreview, onChange }: FileInputProps) { | ||
| const [preview, setPreview] = useState(initialPreview); | ||
| const inputRef = useRef(); | ||
| const inputRef = useRef<HTMLInputElement | null>(null); |
Collaborator
|
어우.. 병훈님 이번 코드. 제 눈에는 딱히 흠 잡을데가 보이지 않는군요 ㄷㄷ 금방 적응하시고 아마 빠르게 멋진 개발자가 되실거라 생각됩니다 ㅎㅎ 😊😊 그 간 함께해주셔서 감사했습니다 ! 앞으로도 개발자 꽃길 되시길 기원드립니다 ! 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
주요 변경사항
스크린샷
멘토에게