-
Notifications
You must be signed in to change notification settings - Fork 40
[우재현] Sprint8 #269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kiJu2
merged 25 commits into
codeit-bootcamp-frontend:React-우재현
from
neruu00:React-우재현-sprint8
Nov 18, 2024
The head ref may contain hidden characters: "React-\uC6B0\uC7AC\uD604-sprint8"
Merged
[우재현] Sprint8 #269
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
8577018
docs: 비동기 처리 커스텀 훅 JSDOC 추가
neruu00 9a20d80
feat: useAsync 개선
neruu00 d13ba4e
refactor: AddItemForm을 AddItemPage로 변경 및 경로 변경
neruu00 391b21c
feat: 중고마켓 페이지 이미지 로드 실패 시 기본 이미지 표기 기능 구현
neruu00 addbbdc
style: 이미지 불러오기 오류 핸들러 이름 변경
neruu00 3dfab92
feat: 상품 상세 컴포넌트 이미지 불러오기 오류 핸들러 추가
neruu00 be3b17b
style: pending 상태명을 loading으로 변경
neruu00 2ff944e
feat: setup cra ts
neruu00 cde515c
feat: typescript 셋업 완료
neruu00 1b9ef2a
feat: typescript 셋업
neruu00 6092f8a
feat: api TS 마이그레이션
neruu00 5876cba
refactor: 환경변수 설정 및 api 이름 변경
neruu00 41c812c
refactor: api.ts에서 interface 코드 다른 .ts 파일로 분할
neruu00 4476f29
feat: ListItem TS 마이그레이션
neruu00 a873a88
feat: 디바이스 타입 콘텍스트 TS 마이그레이션
neruu00 5181b54
feat: 베스트 상품 컴포넌트 TS 마이그레이션
neruu00 13fc055
feat: 페이지네이션 TS 마이그레이션
neruu00 3474bb0
feat: 아이템 리스트 컴포넌트 TS 마이그레이션
neruu00 653cb7d
feat: file input 컴포넌트 TS 마이그레이션
neruu00 e0a4888
상품 상세 TS 마이그레이션
neruu00 913e3e8
fix: 파일 업로드 제한 오류 해결
neruu00 62b5a0a
feat: 상품 상세 페이지 TS 마이그레이션
neruu00 266ce3e
feat: 상품 목록 페이지 TS 마이그레이션
neruu00 b94d4f6
feat: 상품 등록 페이지 TS 마이그레이션
neruu00 626dddc
feat: 질문 폼 TS 마이그레이션
neruu00 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| REACT_APP_API_BASE_URL = "https://panda-market-api.vercel.app" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,7 @@ | ||
| name: delete branch on close pr | ||
|
|
||
| on: | ||
| pull_request: | ||
| types: [closed] | ||
|
|
||
| jobs: | ||
| delete-branch: | ||
| runs-on: ubuntu-latest | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,6 +2,11 @@ | |
| # Edit at https://www.toptal.com/developers/gitignore?templates=react,nextjs,sass | ||
|
|
||
| ### NextJS ### | ||
| <<<<<<< HEAD | ||
| ======= | ||
| # See https://help.github.com/articles/ignoring-files/ for more about ignoring files. | ||
|
|
||
| >>>>>>> cde515c40685c7ea849fcafc91354005f21c13fd | ||
| # dependencies | ||
| /node_modules | ||
| /.pnp | ||
|
|
@@ -59,4 +64,16 @@ sketch | |
| *.sass.map | ||
| *.scss.map | ||
|
|
||
| # End of https://www.toptal.com/developers/gitignore/api/react,nextjs,sass | ||
| <<<<<<< HEAD | ||
| # End of https://www.toptal.com/developers/gitignore/api/react,nextjs,sass | ||
| ======= | ||
| # End of https://www.toptal.com/developers/gitignore/api/react,nextjs,sass | ||
| .env.local | ||
| .env.development.local | ||
| .env.test.local | ||
| .env.production.local | ||
|
|
||
| npm-debug.log* | ||
| yarn-debug.log* | ||
| yarn-error.log* | ||
| >>>>>>> cde515c40685c7ea849fcafc91354005f21c13fd | ||
|
Comment on lines
+67
to
+79
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 컨플릭트 해결 중 누락된 건이 있는 것 같아요 ! |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
컨플릭트 해결 중 누락된 건이 있는 것 같아요 !