[이준희] Sprint12 #346
Merged
[이준희] Sprint12 #346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyh0521
approved these changes
Jan 13, 2025
| const handleChange = (name: string, value: any) => { | ||
| setValues((initialValues) => ({ | ||
| ...initialValues, | ||
| setValues((prevState) => ({ |
Comment on lines
+14
to
+16
| const [pageSize, setPageSize] = useState<number>(() => | ||
| getPageSize("article") | ||
| ); |
Collaborator
There was a problem hiding this comment.
useState 내부에 콜백 함수 잘 사용해주셨네요.
| (error) => Promise.reject(error) | ||
| ); | ||
|
|
||
| instance.interceptors.response.use( |
Collaborator
There was a problem hiding this comment.
interceptor 기능을 잘 활용해주셨네요!
|
|
||
| if (status === 401) { | ||
| // 로컬 스토리지에서 토큰 제거 | ||
| localStorage.removeItem("accessToken"); |
Collaborator
There was a problem hiding this comment.
localStorage에서 사용하는 키 값도 상수로 관리해주셔도 좋을 것 같습니다.
Comment on lines
+13
to
+22
| if (typeof window === "undefined") { | ||
| return context === "default" ? 3 : 10; | ||
| } | ||
|
|
||
| if (context === "item") { | ||
| if (width < 768) return 1; | ||
| if (width < 1280) return 2; | ||
| return 4; | ||
| } | ||
| const width = window.innerWidth; | ||
| const size = pageSize[context]; | ||
|
|
||
| if (width < 768) return 4; | ||
| if (width < 1280) return 6; | ||
| return 10; | ||
| if (width < 768) return size.small; | ||
| if (width < 1280) return size.medium; | ||
| return size.large; |
Collaborator
There was a problem hiding this comment.
상수를 잘 활용해서 코드가 많이 줄어든 것 같습니다.
Comment on lines
+81
to
+93
|
|
||
| const formData = new FormData(); | ||
| formData.append("name", values.name); | ||
| formData.append("favorite", values.favoriteCount.toString()); | ||
| formData.append("description", values.description); | ||
| formData.append("price", values.price.toString()); | ||
|
|
||
| if (values.images) { | ||
| values.images.forEach((image, index) => { | ||
| formData.append(`images[${index}]`, image); | ||
| }); | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
개행 잘해주셔서 가독성이 더 좋아진 것 같습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
중고마켓
상품 상세
상품 등록
심화
주요 변경사항
스크린샷
멘토에게