[오병훈] Sprint12 #348
Merged
[오병훈] Sprint12 #348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhoh032019
added
매운맛🔥
arthurkimdev
approved these changes
Feb 9, 2025
| }; | ||
| const { data, fetchNextPage, hasNextPage, isFetching, isLoading, refetch } = | ||
| useInfiniteQuery( | ||
| ['allArticles', { orderBy, keyword }], |
Collaborator
There was a problem hiding this comment.
이런 key 값들은 보통 queries.ts 파일 하나 생성 수 그 곳에 객체로 관리합니다.
const DEFAULT_KEY = ['']
const QUERY_KEYS = {
ALL_ARTICLES = [...DEFAULT_KEY, 'allArticles'] as const
...
}
| /> | ||
| </div> | ||
| {!loading && articles.length === 0 && ( | ||
| {!isFetching && data?.pages[0]?.list.length === 0 && ( |
Collaborator
There was a problem hiding this comment.
이렇게 data?.pages[0].list 로 접근하기 보다는 변수로 만들어서 접근하면 가독성이 더 좋을 것 같아요~
const queryData = ata?.pages[0]?.list;
Comment on lines
+59
to
61
| if (entry.isIntersecting && hasNextPage && !isFetching) { | ||
| fetchNextPage(); | ||
| } |
Comment on lines
+43
to
+47
| const { data: article = INITIAL_ARTICLE, isLoading: isArticleLoading } = | ||
| useQuery(['article', id], () => getArticles(id), { | ||
| enabled: !!id, | ||
| onError: (error) => console.error('Error fetching article:', error), | ||
| }); |
Collaborator
There was a problem hiding this comment.
해당 쿼리 같은 경우 아래처럼 useArticle.ts 파일에 useQuery를 사용한 커스텀 훅으로 별도로 분리해서 만들게되면 재사용성도 올라가겠죠!?
const useArticle = (id: string) => {
return useQuery<Article, Error>({
queryKey: QUERY_KEYS.article(id),
queryFn: () => getArticles(id),
enabled: !!id,
...defaultOptions,
});
};
Comment on lines
+5
to
6
| import { QueryClient, QueryClientProvider } from 'react-query'; | ||
|
|
Collaborator
There was a problem hiding this comment.
아래와 같은 공통 옵션들을 설정해서 넣을 수 있어요!
const defaultOptions = {
staleTime: 5 * 60 * 1000,
cacheTime: 30 * 60 * 1000,
retry: 3,
// ... 기타 공통 옵션
};
arthurkimdev
merged commit ea6e463
into
codeit-bootcamp-frontend:Next-오병훈
1 check failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
주요 변경사항
'/board'페이지와 관련된 파일들을 수정했습니다.스크린샷
멘토에게