[최제원] sprint7 #270
Merged
[최제원] sprint7 #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kich555
approved these changes
Dec 16, 2024
Comment on lines
+31
to
+32
| console.error("Failed to fetch product by ID:", error); | ||
| throw error; |
| import { ReactComponent as CloseIcon } from "../../assets/images/icons/ic_x.svg"; | ||
|
|
||
| const Button = styled.button` | ||
| background-color: ${({ theme }) => theme.colors.gray[0]}; |
|
|
||
| function DeleteButton({ onClick, label }) { | ||
| return ( | ||
| <Button aria-label={`${label} 삭제`} onClick={onClick}> |
Comment on lines
+20
to
+29
| const fetchProduct = async () => { | ||
| try { | ||
| const data = await getProductsById(productId); | ||
| setProduct(data); | ||
| } catch (error) { | ||
| console.error("Failed to fetch product details:", error); | ||
| } finally { | ||
| setLoading(false); | ||
| } | ||
| }; |
Collaborator
There was a problem hiding this comment.
getProductsById에서 이미 try catch하고 logging처리까지 하고있지 않나요? 그러면 여기의 catch구문에서는
setError 와 같이 UI에 영향이 갈 리액트의 에러상태를 컨트롤하는게 맞아보여요 다시 로그를 찍는것보단 ㅎ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
주요 변경사항
스크린샷
멘토에게
반응형 웹은 만들지 못하였습니다.
위 스크린샷 두 장을 비교해보면 유저에 관한 위치가 다릅니다. 아이패드가 요구사항의 디자인 시안입니다. html 구조를 만들때 잘못 만든건지, 아니면 css로 구현을 하지 못한건지 모르겠지만, 만들다가 막혀서 질문드립니다. 처음에 space-between으로 속성을 주웠는데, 이후 다른 div태그들의 간격을 변경하려고 하니 space-between 속성에 묻혀 변경되지 않아 다른 방법으로 하려고 햇으나, 찾지 못하엿습니다. ㅠㅠ 간단하게라도 설명해주시면 이후 찾아서 만들어보겠습니다 !! 감사합니다 !!
셀프 코드 리뷰를 통해 질문 이어가겠습니다.