-
Notifications
You must be signed in to change notification settings - Fork 37
[김소영] sprint7 #271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kich555
merged 16 commits into
codeit-bootcamp-frontend:React-김소영
from
kimsoyoung96:React-김소영-sprint7
Dec 16, 2024
The head ref may contain hidden characters: "React-\uAE40\uC18C\uC601-sprint7"
Merged
[김소영] sprint7 #271
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
c11fae5
items에서 최신순/좋아요순 클릭 시 변경되는 이벤트 추가
kimsoyoung96 4cf5fcc
/items에서 베스트상품 기본 4개 띄우려고 slice 사용
kimsoyoung96 d1579e6
Home.jsx에서 필요없는 함수와 태그 삭제
kimsoyoung96 3d2f34e
form태그 스타일 삭제
kimsoyoung96 e547d7b
미디어쿼리에서 최대너비값 삭제 및 padding값 합치기
kimsoyoung96 188d21b
베스트아이템 영역을 grid로 바꾸고 미디어쿼리 추가
kimsoyoung96 c5f8598
전체상품 영역을 grid로 바꾸고 미디어쿼리 추가
kimsoyoung96 d355d71
상품검색영역에 미디어쿼리를 추가하고 flex 칸을 order로 위치변경
kimsoyoung96 0eea259
Additem.jsx에 form미디어쿼리 추가
kimsoyoung96 617ecaa
상품검색영역만 높이를 변경하도록 스타일 추가 및 변경
kimsoyoung96 61bc1a2
페이지네이션 레이아웃 추가
kimsoyoung96 b2271f6
Nav 따로 컴포넌트에서 작업(Home컴포넌트에 import가 많고, 중고마켓에 링크를 매번 적용시키기 위함)
kimsoyoung96 4595589
Nav 컴포넌트 변경에 따른 코드 수정
kimsoyoung96 b30d603
필요없는 컴포넌트들 삭제
kimsoyoung96 c81e548
코드리뷰 받은 에러처리, 예외처리 코드 반영
kimsoyoung96 d60f178
코드리뷰 받은 버튼타입 추가하기(text 프롭스를 유연하게 받아보는 방법은 반영까지 시간이 좀 더 필요할 것 같습니다)
kimsoyoung96 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,11 @@ | ||
| import './Button.css'; | ||
|
|
||
| const Button = ({ text, type }) => { | ||
| return <button className={`Button Button_${type}`}>{text}</button>; | ||
| return ( | ||
| <button type={type} className={`Button Button_${type}`}> | ||
| {text} | ||
| </button> | ||
| ); | ||
| }; | ||
|
|
||
| export default Button; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍👍👍