[김경기] sprint8 #282
Merged
[김경기] sprint8 #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devToram
approved these changes
Jan 7, 2025
Comment on lines
+24
to
+30
| function getPageSize(width: number): number { | ||
| if (width <= 767) { | ||
| return 4; // 화면 너비가 768px 미만이면 한 페이지에 4개 | ||
| } else if (width <= 1199) { | ||
| return 6; // 화면 너비가 768px 이상이면 한 페이지에 6개 | ||
| } else { | ||
| return 10; // 화면 너비가 1200px 이상이면 한 페이지에 10개 |
Collaborator
There was a problem hiding this comment.
요기 사용하는 수들을 묶어서 object 로 만들어도 좋을 거 같아요!
| getPageSize(window.innerWidth) | ||
| ); // 페이지 크기 상태 | ||
| const [currentPage, setCurrentPage] = useState<number>(1); // 현재 페이지 상태 | ||
| const [orderBy, setOrderBy] = useState<string>("recent"); // 정렬 기준 (최신순) |
Collaborator
There was a problem hiding this comment.
여기는 그냥 string 이 아닌 "recent" 등과 같이 정해진 string 만 올 수 있기 때문에 그 string 들을 묶은 타입을 만드는 걸 추천드려요!
type SortCategory = "recent" as const | "name" as const
| onPageChange, | ||
| }: PaginationProps) { | ||
| const totalPages = Math.ceil(totalItems / itemsPerPage); // 전체 페이지 수 계산 | ||
| const pageRange = 5; // 한 번에 보여줄 페이지 버튼 개수 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
주요 변경사항
멘토에게