[박상석] Sprint8 #291
Merged
[박상석] Sprint8 #291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ithub-actions [Fix] delete merged branch github action
…상석-sprint1 [박상석]sprint1
…상석-sprint2 Basic 박상석 sprint2
added 19 commits
November 24, 2024 14:28
added 7 commits
January 12, 2025 23:50
kich555
approved these changes
Jan 20, 2025
Collaborator
kich555
left a comment
kich555
left a comment
There was a problem hiding this comment.
넵 전체적으로 특별히 모난곳은 없네요 ㅎㅎ
고생하셨습니다
|
|
||
| currentPage: number; | ||
| totalPage: number; | ||
| setPage: React.Dispatch<React.SetStateAction<number>>; |
Collaborator
There was a problem hiding this comment.
()=> void 그냥 이렇게 작성하셔도 괜찮습니다. ㅎ
사용하신 방법이 정석은 맞는데 너무 길어서..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
주요 변경사항
-moule.css로 변경
-기초 프로젝트 후 배운 점 토대로 코드 리팩토링
멘토에게
-공통으로 사용하는 Container 컴포넌트1개가 있습니다.
html에 Container 컴포넌트가 있는 상황인데 가독성에 안좋은 느낌을 받고 있는데
이런 상황 괜찮은건가요?
그리고 현재는 구성되어 있지 않지만 style.box 한개가 더 있다는 가정하에
2개를 가로 정렬을 해야 한다고 했을 때 부모 div 를 만들어서 정렬 하는게 나을까요?
아니면 Container에 className props으로 적용하는 게 좋을까요?
이런 상황이 종종 있는데 Container에 클래스 줘서 하면 좋은데 가운데영역이라는 역할이 있어서
궁금해서 질문드립니다!
-현재 프로젝트에는 대부분 interface로 많이 적용되어 있습니다.
구동은 되고 있는데 interface로만 작성하다보니 이게 맞나 하는 의문이 들고 있습니다.
-https://codeit02-pandamarket.netlify.app/items