[김승석] Sprint9 #299
Merged
[김승석] Sprint9 #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
January 18, 2025 01:42
kss761036
commented
Jan 18, 2025
| ? console.log("모바일") | ||
| : isTa && isMount | ||
| ? console.log("타블렛") | ||
| : console.log("피씨"); |
Collaborator
Author
There was a problem hiding this comment.
모바일 사이즈 적용 후 새로고침 하면
콘솔에 피씨가 잠깐 적용되는데 이유가 뭘까요,,
Collaborator
There was a problem hiding this comment.
useEffect는 초기 렌더링이 이미 시작된 이후에 실행되는 훅입니다.
때문에 원하는 결과를 도출하려면 useEffect() 아래에
if (!isMount) {
return null;
}을 두어 초기 렌더링 중일 때 아무 것도 렌더링하지 않게 해야합니다
kich555
approved these changes
Jan 20, 2025
src/pages/boards/index.tsx
Outdated
Comment on lines
6
to
13
| export const getServerSideProps = async () => { | ||
| const list = await fetchBoardList(1, 3, "like"); | ||
| return { | ||
| props: { | ||
| list, | ||
| }, | ||
| }; | ||
| }; |
Collaborator
There was a problem hiding this comment.
getServerSideProps 같은거 써보시는것도 좋습니다 ㅎ
src/pages/boards/index.tsx
Outdated
Comment on lines
19
to
22
| const date = new Date(dateString); | ||
| const year = date.getFullYear(); | ||
| const month = String(date.getMonth() + 1).padStart(2, "0"); | ||
| const day = String(date.getDate()).padStart(2, "0"); |
Collaborator
There was a problem hiding this comment.
dayjs()같은 라이브러리를 사용하는게 좀더 편리할거에요
src/pages/boards/index.tsx
Outdated
| <> | ||
| <div className="common_title">베스트 게시글</div> | ||
| <ul className={styles.board_best}> | ||
| {list.length === 0 ? ( |
Collaborator
There was a problem hiding this comment.
lodash같은 라이브러리를 사용해보는건 어떤가요?
src/pages/boards/index.tsx
Outdated
Comment on lines
10
to
11
| const list = await fetchBoardList(1, 3, "like"); | ||
| const commonList = await fetchBoardList(1, 10, "recent"); |
Collaborator
There was a problem hiding this comment.
이런식으로 코드를 작성하면 waterfall이 발생할 것 같아요 Promise.all을 활용해보는건 어떤가요?
src/pages/boards/index.tsx
Outdated
Comment on lines
19
to
33
| const fetchData = async () => { | ||
| try { | ||
| const bestResponse = await fetchBoardList(1, 3, "like"); | ||
| const commonResponse = await fetchBoardList(1, 10, order); | ||
|
|
||
| setList(bestResponse); | ||
| setCommonList(commonResponse); | ||
| } catch (error) { | ||
| console.error("데이터 가져오기 실패:", error); | ||
| } | ||
| }; | ||
|
|
||
| useEffect(() => { | ||
| fetchData(); | ||
| }, [order]); |
Collaborator
There was a problem hiding this comment.
이런식으로 작성하려면 fetchData를 useCallback으로 만들고 useEffect의 의존성 배열에 fetchData를 집어넣어야해요
Comment on lines
44
to
52
| const onSearch: React.ChangeEventHandler<HTMLInputElement> = (e) => { | ||
| setSearch(e.target.value); | ||
| }; | ||
|
|
||
| const onSearchEnter: React.KeyboardEventHandler<HTMLInputElement> = (e) => { | ||
| if (e.key === "Enter") { | ||
| setKeyword(search); | ||
| } | ||
| }; |
Collaborator
There was a problem hiding this comment.
form과 submit이벤트를 활용하는게 더 시멘틱 해 보이네요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
멘토에게