[김경기] sprint9 #303
Merged
[김경기] sprint9 #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ithub-actions [Fix] delete merged branch github action
devToram
approved these changes
Jan 20, 2025
| function getPageSize(width: number): number { | ||
| if (width <= PAGE_SIZES.small.max) { | ||
| return PAGE_SIZES.small.size; | ||
| } else if (width <= PAGE_SIZES.medium.max) { |
Collaborator
There was a problem hiding this comment.
early return 이라 else 없어도 될 거 같아요~
|
|
||
| const AllProducts = () => { | ||
| const [products, setProducts] = useState<Product[]>([]); // 상품 데이터 상태 | ||
| const [pageSize, setPageSize] = useState<number>(4); // 초기 페이지 크기 설정 (10개로 설정) |
Collaborator
There was a problem hiding this comment.
주석은 10개로 설정인데 실제 값은 4개네요😮
| import ProductList from "./products"; | ||
| import Pagination from "./pagination"; | ||
| import styles from "./allProduct.module.css"; | ||
| import windowView from "@/hooks/windowView"; // 커스텀 훅 임포트 |
| // Props 타입 정의 | ||
| interface NavBarProps { | ||
| orderBy: "recent" | "favorite"; // 'recent' 또는 'favorite'만 가능 | ||
| setOrderBy: (order: "recent" | "favorite") => void; // setOrderBy는 'recent' 또는 'favorite'만 받을 수 있음 |
Collaborator
There was a problem hiding this comment.
계속 쓰이는 type 이라 따로 타입을 만들어도 좋을 거 같아요!
type OrderBy = "recent" | "favorite"
| </Link> | ||
| {/* 드롭다운 버튼 */} | ||
| <button className={styles.dropdown_btn} onClick={toggleDropdown}> | ||
| {orderBy === "recent" ? "최신순" : "좋아요순"}{" "} |
Collaborator
There was a problem hiding this comment.
"recent", "최신순" 이 바로 참조가 가능하도록 상수를 만들어도 좋겠네요~
const ORDER = {
recent: {
displayName: "최신순",
value: 'recent'
}
}
요런 느낌으로요!
| onPageChange: (page: number) => void; // 페이지 변경 시 호출되는 함수 | ||
| } | ||
|
|
||
| const pageRange = 5; // 한 번에 보여줄 페이지 버튼 개수 |
Collaborator
There was a problem hiding this comment.
상수는 대문자로 적어주시는 걸 추천드려요!
Suggested change
| const pageRange = 5; // 한 번에 보여줄 페이지 버튼 개수 | |
| const PAGE_RANGE = 5; // 한 번에 보여줄 페이지 버튼 개수 |
|
|
||
| const pageRange = 5; // 한 번에 보여줄 페이지 버튼 개수 | ||
|
|
||
| function Pagination({ |
Collaborator
There was a problem hiding this comment.
페이지네이션의 경우 다양한 곳에 쓰일 수 있어서 AllProdcuts 말고 Common 같은 곳에 묶어줘도 좋겠네요!
Comment on lines
+13
to
+17
| const isItemsPage = router.pathname === "/items"; | ||
| const isBoardPage = router.pathname === "/boards"; | ||
| const isAddItemPage = router.pathname === "/additem"; | ||
| const isMainPage = router.pathname === "/"; | ||
| const isItemsDetailPage = router.pathname.startsWith("/items/"); |
Collaborator
There was a problem hiding this comment.
각 페이지에 있는지를 모두 체크하는 것보다 자유게시판으로 보여줄 url 배열, 중고마켓으로 보여줄 url 배열을 만들어서 여기에 해당하는지 체크하는 것도 고려해주세요~
| async function fetchProduct() { | ||
| if (id) { | ||
| try { | ||
| const data = await getProductDetails(id as string); // id를 string으로 캐스팅 |
Collaborator
There was a problem hiding this comment.
id 가 기본적으로 string 으로 추정되지 않나요??
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
멘토에게