Skip to content

[신주하] Sprint2 #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kiJu2 merged 1 commit into from
Dec 31, 2024
Merged

[신주하] Sprint2 #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added desktop_01.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added desktop_02.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added desktop_03.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added desktop_04.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added desktop_05.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
106 changes: 106 additions & 0 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,106 @@
<!DOCTYPE html>
<html lang="ko">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />

<title>판다마켓</title>
<link rel="icon" href="desktop_01.png" >

<link rel="stylesheet" as="style"
crossorigin href="https://cdn.jsdelivr.net/gh/orioncactus/[email protected]/dist/web/static/pretendard.min.css"/>

<link rel="stylesheet" href="styles/global.css" />
<link rel="stylesheet" href="styles/home.css" />

</head>

<body>
<header>
<a href="/"><img src="logo1.jpg" alt="판다마켓 홈" width="153"/></a>
<a href="login.html"><img src="login.png" class="button" alt="로그인"></a>

</header>

<main>
<section id="hero" class="banner">
<div class="wrapper">
<h1>
일상의 모든 물건을<br/>
거래해 보세요
</h1>
<a href="items.html" class="button">구경하러 가기</a>
</div>
</section>

<section id="fetures" class="wrapper">
<div class="feature">
<img src="desktop_02.png" alt="인기 상품" width="50%" />

<div class="feature-content">
<h2 class="feature-tag">Hot item</h2>
<h1>인기 상품을<br/>확인해 보세요</h1>
Copy link
Collaborator

@kiJu2 kiJu2 Dec 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<h1> 태그는 문서에 하나만 넣는게 어떨까요?

이하 MDN 발췌

페이지 당 하나의 <h1>만 사용하세요. 여러 개를 써도 오류는 나지 않겠지만, 단일 <h1>이 모범 사례로 꼽힙니다. 논리적으로 생각했을 때도, <h1>은 가장 중요한 제목이므로 전체 페이지의 목적을 설명해야 할 것입니다. 두 개의 제목을 가진 책이나, 여러 개의 이름을 가진 영화는 볼 수 없죠! 또한 스크린 리더 사용자와 SEO에도 더 적합합니다.

MDN <h1>-<h6>: HTML 구획 제목 요소

<p class="feature-description">
가장 HOT한 중고거래 물품을<br/>판다마켓에서 확인해 보세요
</p>
</div>
</div>

<div class="feature">
<div class="feature-content">
<h2 class="feature-tag">Search</h2>
<h1>구매를 원하는<br/>상품을 검색하세요</h1>
<p class="feature-description">
구매하고 싶은 물품은 검색해서
<br/>쉽게 찾아보세요
</p>
</div>
<img src="desktop_03.png" alt="검색 기능" width="50%" />
</div>

<div class="feature">
<img src="desktop_04.png" alt="판매 상품 등록" width="50%"/>
<div class="feature-content">
<h2 class="feature-tag">Register</h2>
<h1>판매를 원하는<br/>상품을 등록하세요</h1>
<p class="feature-description">
어떤 물건이든 판매하고 싶은 상품을
<br/>쉽게 등록하세요
</p>
</div>
</div>
</section>

<section id="bottomBanner" class="banner">
<div class="wapper">
<h1>
믿을 수 있는
<br />
판다마켓 중고거래
</h1>
</div>
</section>
</main>

<footer>
<div>©codeit - 2024</div>
<div id="footerMenu"> <a href="privacy.html">Privacy</a> <a href="faq.html">FAQ</a>
</div>

<div id="socialMedia">
<a href="https://www.facebook.com/" target="_blank" rel="noopener noreferrer">
<img src="logo1.jpg" alt="페이스북" width="20" /></a>


<a href="https://twitter.com/" target="_blank" rel="noopener noreferrer">
<img src="logo2.jpg" alt="트위터" width="20" /></a>

<a href="https://www.youtube.com/" target="_blank" rel="noopener noreferrer">
<img src="logo3.jpg" alt="유튜브" width="20" /></a>

<a href="https://www.instagram.com/" target="_blank" rel="noopener noreferrer">
<img src="logo1.jpg" alt="인스타그램" width="20" /></a>
</div>
Comment on lines +90 to +103
Copy link
Collaborator

@kiJu2 kiJu2 Dec 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(제안/선택)요소들이 순서 없는 목록을 의미한다면 <ul>과 <li>로도 나타낼 수 있습니다 !

<ul class="footer-social">
  <li>
	<a target="_blank" href="https://www.facebook.com/">
	  <img src="images/ic_facebook.svg" alt="페이스북" />
	</a>
  </li>
  <li>
	<a target="_blank" href="https://www.twitter.com/">
	  <img src="images/ic_twitter.svg" alt="트위터" />
	</a>
  </li>
  <li>
	<a target="_blank" href="https://www.youtube.com/">
	  <img src="images/ic_youtube.svg" alt="유튜브" />
	</a>
  </li>
  <li>
	<a target="_blank" href="https://www.instagram.com/">
	  <img src="images/ic_instagram.svg" alt="인스타그램" />
	</a>
  <li>
</ul>

MDN: HTML <ul> 요소는 정렬되지 않은 목록을 나타냅니다. 보통 불릿으로 표현합니다.

li 태그의 기본 스타일을 제거하고 싶다면 다음과 같이 작성할 수 있습니다 ! { list-style: none; }

</footer>
</body>
</html>
Binary file added login.png
View file
Open in desktop
Copy link
Collaborator

@kiJu2 kiJu2 Dec 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

해당 버튼은 css로 작성하시는게 바람직합니다 !

padding과 background-color 그리고 border-radius 등으로 같은 UI를 출력할 수 있습니다 😊

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added logo1.jpg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added logo2.jpg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added logo3.jpg
View file
Open in desktop
Copy link
Collaborator

@kiJu2 kiJu2 Dec 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

로고 파일 하나만 있어도 됩니다 !

하나의 로고파일로 크기를 조정하여 개발할 수 있습니다 !
다음과 같이요 !

<img src="..." class="logo" />

// ...
.logo { width: 200px }

Copy link
Collaborator

@kiJu2 kiJu2 Dec 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

또한 벡터 이미지는 svg로 저장하시는걸 추천드려요 !

이하 MDN
SVG(Scalable Vector Graphics)는 2차원 벡터 그래픽을 서술하는 XML 기반의 마크업 언어입니다. SVG는 텍스트 기반의 열린 웹 표준 중 하나로, 모든 사이즈에서 깔끔하게 렌더링 되는 이미지를 서술하며 CSS, DOM, JavaScript, SMIL (en-US) 등 다른 웹 표준과도 잘 동작하도록 설계됐습니다. SVG는 달리 말하자면 HTML과 텍스트의 관계를 그래픽에 적용한 것입니다

image

이미지 파일은 최소 단위가 픽셀로 되어있으며 확대했을 때 이미지가 깨질 수 있어요 !
피그마에서 export하실 때에 svg로 export할 수 있습니다 😊

Rester vs Vector

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added logo_login.png
View file
Open in desktop
Copy link
Collaborator

@kiJu2 kiJu2 Dec 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

해당 이미지 파일도 css를 통하여 개발되어야 합니다 😊

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added standard=pc.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading