Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,11 @@ on:
pull_request:
types: [closed]

permissions:
pull-requests: write

jobs:
delete-branch:
runs-on: ubuntu-latest
steps:
- name: delete branch
uses: SvanBoxel/delete-merged-branch@main
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
1 change: 1 addition & 0 deletions fanda-market/faq.html
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
<!-- faq -->
107 changes: 107 additions & 0 deletions fanda-market/global.css
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

크으 global.css가 정말 유용하겠군요 !

훌륭합니다 ! 이제 서비스 전반적으로 사용되는 스타일은 global.css에 적용하면 되겠군요 ! 👍

Original file line number Diff line number Diff line change
@@ -0,0 +1,107 @@
/* ========================================
Global Styles
======================================== */
:root {
/* color */
--primary-100: #3692ff;
--primary-200: #1967d6;
--primary-300: #1251aa;

--error-color: #f74747;

--gray-900: #111827;
--gray-800: #1f2937;
--gray-700: #374151;
--gray-600: #4b5563;
--gray-500: #6b7280;
--gray-400: #9ca3af;
--gray-200: #e5e7eb;
--gray-100: #f3f4f6;
--gray-50: #f9fafb;

/* font */
--font-weight-bold: 700;
--font-weight-semibold: 600;
--font-weight-medium: 500;
--font-weight-regular: 400;
}

Comment on lines +4 to +28
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿 ! 컬러 팔레트를 정의하셨네요.

앞으로 컬러와 관련된 내용들은 재사용하여 처리될 수 있겠어요. 👍👍

/* setting */
html,
a {
font-family: "Pretendard Variable", Pretendard, sans-serif;
font-size: 16px;
font-weight: var(--font-weight-regular);
color: var(--gray-700);
}
.img_box {
line-height: 0;
}

/* ========================================
Components
======================================== */
/* button */
.btn {
display: block;
font-weight: var(--font-weight-semibold);
text-align: center;
color: var(--gray-100);
background-color: var(--primary-100);
}
.btn--large {
width: 357px;
height: 56px;
line-height: 56px;
border-radius: 40px;
}
.btn--medium {
width: 240px;
height: 48px;
line-height: 48px;
border-radius: 40px;
}
.btn--small_40 {
width: 88x;
height: 42px;
line-height: 42px;
border-radius: 8px;
}
.btn--small_48 {
width: 88px;
height: 48px;
line-height: 48px;
border-radius: 8px;
}
.btn--white {
background-color: var(--gray-50);
border: 1px solid var(--primary-100);
}
Comment on lines +45 to +79
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

크으 깔끔하고 재사용하기 좋은 클래스입니다 ! 👍👍


/* button - heart */
.btn-heart {
border-radius: 35px;
color: var(--gray-500);
background-color: #fff;
}
.btn-heart--large {
width: 87px;
height: 40px;
line-height: 40px;
}
.btn-heart--small {
width: 79px;
height: 32px;
line-height: 32px;
}

/* button - hover, click, inactive */
.btn__hover {
background-color: var(--primary-200);
}
.btn__click {
background-color: var(--primary-300);
}
.btn__inactive {
background-color: var(--gray-400);
}
Binary file added fanda-market/img/desktop.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added fanda-market/img/export/Img_home_01.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added fanda-market/img/export/Img_home_02.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added fanda-market/img/export/Img_home_03.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added fanda-market/img/export/Property 1=md.png
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

벡터 이미지는 svg로 저장하시는걸 추천드려요 !

이하 MDN
SVG(Scalable Vector Graphics)는 2차원 벡터 그래픽을 서술하는 XML 기반의 마크업 언어입니다. SVG는 텍스트 기반의 열린 웹 표준 중 하나로, 모든 사이즈에서 깔끔하게 렌더링 되는 이미지를 서술하며 CSS, DOM, JavaScript, SMIL (en-US) 등 다른 웹 표준과도 잘 동작하도록 설계됐습니다. SVG는 달리 말하자면 HTML과 텍스트의 관계를 그래픽에 적용한 것입니다

image

이미지 파일은 최소 단위가 픽셀로 되어있으며 확대했을 때 이미지가 깨질 수 있어요 !
피그마에서 export하실 때에 svgexport할 수 있습니다 😊

Rester vs Vector

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

또한, 현재 크기 별로 이미지를 저장하셨습니다.

사용되지 않는 이미지들은 제거하시는게 좋을 것 같아요 ㅎㅎㅎ

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added fanda-market/img/export/gnb/ic_facebook.png
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

해당 아이콘들도 svg로 사용하시는걸 권장드립니다 ! 👍

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added fanda-market/img/export/gnb/ic_instagram.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added fanda-market/img/export/gnb/ic_twitter.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added fanda-market/img/export/gnb/ic_youtube.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added fanda-market/img/ic_facebook.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added fanda-market/img/ic_instagram.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added fanda-market/img/ic_twitter.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added fanda-market/img/ic_youtube.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added fanda-market/img/landing-page/Img_home_01.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added fanda-market/img/landing-page/Img_home_02.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added fanda-market/img/landing-page/Img_home_03.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added fanda-market/img/landing-page/Img_home_bottom.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added fanda-market/img/landing-page/Img_home_top.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

해당 섹션의 이미지들은 필요 없을 것 같아요 !

해당 섹션의 이미지들은 htmlcss로 만드는 것이 미션의 목표입니다 !

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added fanda-market/img/logo.png
117 changes: 117 additions & 0 deletions fanda-market/index.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,117 @@
<!DOCTYPE html>
<html lang="ko">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>판다마켓</title>
<link
rel="stylesheet"
as="style"
crossorigin
href="https://cdn.jsdelivr.net/gh/orioncactus/[email protected]/dist/web/static/pretendard.min.css"
/>
<link rel="stylesheet" href="./style.css" />
</head>
<body>
<div id="container">
<header id="header">
<div id="gnb">
<h1>
<a href="/">
<img src="./img/logo.png" alt="logo" class="logo_img" />
</a>
</h1>
<a href="/login" class="btn btn--small_48 login">로그인</a>
</div>
</header>
<main>
<div class="banner top">
<div class="text_box">
<p class="oneline">일상의 모든 물건을 거래해 보세요</p>
<p class="twolines">일상의 모든 물건을</p>
<p class="twolines">거래해 보세요</p>
<a href="/items" class="btn btn--large">구경하러 가기</a>
</div>
<div class="img_box">
<img
src="./img/landing-page/Img_home_top.png"
alt="판다 캐릭터 이미지"
/>
</div>
</div>
<div class="content">
<section class="sec1">
<div class="sec__wrapper">
<div class="img_box"></div>
<div class="text_box">
<p class="tag">Hot item</p>
<p class="title oneline">인기 상품을 확인해 보세요</p>
<p class="title twolines">인기 상품을</p>
<p class="title twolines">확인해 보세요</p>
<p class="text">
가장 HOT한 중고거래 물품을<br />
판다 마켓에서 확인해 보세요
</p>
</div>
</div>
</section>
Comment on lines +43 to +57
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(생각해보기)해당 섹션 내 모든 내용이 "문구"로 되어있군요 !

현재:
단락: 인기 상품을 확인해보세요.
단락: 인기 상품을
단락: 확인해 보세요
단락: 가장 HOT한 중고거래 물품을 판다 마켓에서 확인해 보세요

라는 의미를 가지고 있어요.

(제안) 다음과 같은 의미를 가질 수 있도록 내용을 변경해보시는건 어떨까요?
제목2: 인기 상품을 확인해 보세요
단락: 가장 HOT한 중고거래 물품을 판다 마켓에서 확인해 보세요

<section class="sec2">
<div class="sec__wrapper">
<div class="img_box"></div>
<div class="text_box">
<p class="tag">Search</p>
<p class="title oneline">구매를 원하는 상품을 검색하세요</p>
<p class="title twolines">구매를 원하는</p>
<p class="title twolines">상품을 검색하세요</p>
<p class="text">
구매하고 싶은 물품은 검색해서<br />쉽게 찾아보세요
</p>
</div>
</div>
</section>
<section class="sec3">
<div class="sec__wrapper">
<div class="img_box"></div>
<div class="text_box">
<p class="tag">Register</p>
<p class="title oneline">판매를 원하는 상품을 등록하세요</p>
<p class="title twolines">판매를 원하는</p>
<p class="title twolines">상품을 등록하세요</p>
<p class="text">
어떤 물건이든 판매하고 싶은 상품을<br />쉽게 등록하세요
</p>
</div>
</div>
</section>
</div>
<div class="banner bottom">
<div class="text_box">
<p>믿을 수 있는</p>
<p>판다마켓 중고 거래</p>
</div>
<div class="img_box">
<img
src="./img/landing-page/Img_home_bottom.png"
alt="판다 캐릭터 이미지"
/>
</div>
</div>
</main>
<footer id="footer">
<div class="footer__wrapper">
<div class="copyright">©codeit - 2024</div>
<div class="corp_list">
<a href="/privacy">Privacy Policy</a>
<a href="/faq">FAQ</a>
</div>
<div class="footer-sns">
<a target="_blank" href="/" class="icon facebook"> </a>
<a target="_blank" href="/" class="icon twitter"> </a>
<a target="_blank" href="/" class="icon youtube"> </a>
<a target="_blank" href="/" class="icon insta"> </a>
</div>
</div>
</footer>
</div>
</body>
</html>
1 change: 1 addition & 0 deletions fanda-market/items.html
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
<!-- items -->
1 change: 1 addition & 0 deletions fanda-market/login.html
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
<!-- login -->
1 change: 1 addition & 0 deletions fanda-market/privacy.html
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
<!-- privacy -->
127 changes: 127 additions & 0 deletions fanda-market/reset.css
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

크으 reset.css까지 적용하셨군요 !

이제 수연님의 제품은 대부분의 디바이스와 브라우저에서 같은 UI를 보여줄 수 있겠군요 ! 👍

Original file line number Diff line number Diff line change
@@ -0,0 +1,127 @@
html,
body,
div,
span,
applet,
object,
iframe,
h1,
h2,
h3,
h4,
h5,
h6,
p,
blockquote,
pre,
a,
abbr,
acronym,
address,
big,
cite,
code,
del,
dfn,
em,
img,
ins,
kbd,
q,
s,
samp,
small,
strike,
strong,
sub,
sup,
tt,
var,
b,
u,
i,
center,
dl,
dt,
dd,
ol,
ul,
li,
fieldset,
form,
label,
legend,
table,
caption,
tbody,
tfoot,
thead,
tr,
th,
td,
article,
aside,
canvas,
details,
embed,
figure,
figcaption,
footer,
header,
hgroup,
menu,
nav,
output,
ruby,
section,
summary,
time,
mark,
audio,
video {
margin: 0;
padding: 0;
border: 0;
font-size: 100%;
font: inherit;
vertical-align: baseline;
}
/* HTML5 display-role reset for older browsers */
article,
aside,
details,
figcaption,
figure,
footer,
header,
hgroup,
menu,
nav,
section {
display: block;
}
body {
line-height: 1;
}
ol,
ul {
list-style: none;
}
blockquote,
q {
quotes: none;
}
blockquote:before,
blockquote:after,
q:before,
q:after {
content: "";
content: none;
}
table {
border-collapse: collapse;
border-spacing: 0;
}
a {
text-decoration: none;
}
Loading
Loading