Skip to content

[황준호] sprint3 #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kiJu2 merged 2 commits into from
Jan 24, 2025
Merged

[황준호] sprint3 #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e96bf52
style : 반응형 스타일 적용
mecrojun Jan 23, 2025
fa6a9a0
Merge branch 'codeit-bootcamp-frontend:Basic-황준호' into Basic-황준호
mecrojun Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions SprintMission/images/btn_visibility_on.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added SprintMission/images/panda_mobile_logo.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
84 changes: 43 additions & 41 deletions SprintMission/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,59 +25,61 @@
<div class="section-wrap">
<div class="intro">
<h2>
일상의 모든 물건을<br />
일상의 모든 물건을
거래해 보세요
</h2>
<a href="./items.html">구경하러 가기</a>
</div>
<div class="img"></div>
</div>
</section>
<section class="info-section">
<div class="section-wrap">
<div class="img1"></div>
<div class="discribe area1">
<span>Hot item</span>
<div>
<h2>
인기 상품을<br />
확인해 보세요
</h2>
<p>가장 HOT한 중고거래 물품을 판다 마켓에서 확인해 보세요</p>
<div class="info-section-wrap">
<section class="info-section">
<div class="section-wrap">
<div class="img1"></div>
<div class="discribe area1">
<span>Hot item</span>
<div class="context1">
<h2>
인기 상품을
확인해 보세요
</h2>
<p>가장 HOT한 중고거래 물품을 판다 마켓에서 확인해 보세요</p>
</div>
</div>
</div>
</div>
</section>
<section class="info-section">
<div class="section-wrap">
<div class="discribe area2">
<span>Search</span>
<div>
<h2>
구매를 원하는<br />
상품을 검색하세요
</h2>
<p>구매하고 싶은 물품은 검색해서 쉽게 찾아보세요</p>
</div>
</section>
<section class="info-section">
<div class="section-wrap reverse-section">
<div class="img2"></div>
<div class="discribe area2">
<span>Search</span>
<div class="context2">
<h2>
구매를 원하는
상품을 검색하세요
</h2>
<p>구매하고 싶은 물품은 검색해서 쉽게 찾아보세요</p>
</div>
</div>
</div>
<div class="img2"></div>
</div>
</section>
<section class="info-section">
<div class="section-wrap">
<div class="img3"></div>
<div class="discribe area3">
<span>Register</span>
<div>
<h2>
판매를 원하는<br />
상품을 등록하세요
</h2>
<p>어떤 물건이든 판매하고 싶은 상품을 쉽게 등록하세요</p>
</section>
<section class="info-section">
<div class="section-wrap">
<div class="img3"></div>
<div class="discribe area3">
<span>Register</span>
<div class="context3">
<h2>
판매를 원하는
상품을 등록하세요
</h2>
<p>어떤 물건이든 판매하고 싶은 상품을 쉽게 등록하세요</p>
</div>
</div>
</div>
</div>
</section>
</section>
</div>
<section class="footer-section">
<div class="section-wrap">
<div class="intro">
Expand Down
5 changes: 4 additions & 1 deletion SprintMission/login.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,10 @@
</div>
<div class="password">
<label>비밀번호</label>
<input type="password" class="user-password" name="user-password" placeholder="비밀번호를 입력해주세요" required>
<div class="password-wrap">
<input type="password" class="user-password" name="user-password" placeholder="비밀번호를 입력해주세요" required>
<svg class="password-visbility"></svg>
Copy link
Collaborator

@kiJu2 kiJu2 Jan 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(제안) svg 태그 그대로 작성해볼 수도 있습니다:

Suggested change
<svg class="password-visbility"></svg>
<svg
class="password-visibility"
width="24"
height="24"
viewBox="0 0 24 24"
xmlns="http://www.w3.org/2000/svg"
role="button"
aria-label="비밀번호 보기"
>
<path
d="M12 4.5C7.05 4.5 2.73 7.61 1 12c1.73 4.39 6.05 7.5 11 7.5s9.27-3.11 11-7.5c-1.73-4.39-6.05-7.5-11-7.5zm0 12c-2.48 0-4.5-2.02-4.5-4.5S9.52 7.5 12 7.5 16.5 9.52 16.5 12 14.48 16.5 12 16.5zm0-7c-1.38 0-2.5 1.12-2.5 2.5S10.62 14.5 12 14.5 14.5 13.38 14.5 12 13.38 9.5 12 9.5z"
fill="#000"
/>
</svg>

background-image로 설정된다면 스크린 리더와 같은 보조 기술에서 무시될 수 있어요. 시각적으로만 표시되며, 의미 전달이 필요할 경우 부적합할 수 있습니다. 😊

Copy link
Collaborator

@kiJu2 kiJu2 Jan 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

혹은 다음과 같이 <img 태그를 사용해볼 수 있어요 😊:

Suggested change
<svg class="password-visbility"></svg>
<img
class="password-visibility"
src="images/btn_visibility_on.svg"
alt="비밀번호 보기"
role="button"
/>

</div>
</div>
<a href="#" class="login-btn">로그인</a>
</div>
Expand Down
10 changes: 8 additions & 2 deletions SprintMission/signup.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,17 @@
</div>
<div>
<label>비밀번호</label>
<input type="password" class="user-password" name="user-password" placeholder="비밀번호를 입력해주세요" required>
<div class="password-wrap">
<input type="password" class="user-password" name="user-password" placeholder="비밀번호를 입력해주세요" required>
<svg class="password-visbility"></svg>
</div>
</div>
<div>
<label>비밀번호 확인</label>
<input type="password" class="user-checkPassword" name="user-checkPassword" placeholder="비밀번호를 다시 한 번 입력해주세요" required>
<div class="password-check-wrap">
<input type="password" class="user-checkPassword" name="user-checkPassword" placeholder="비밀번호를 다시 한 번 입력해주세요" required>
<svg class="password-visbility"></svg>
</div>
</div>
</div>
<a href="#" class="signUp-btn">회원가입</a>
Expand Down
Loading
Loading