[송미진] sprint8 #144
Merged
[송미진] sprint8 #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongqui
approved these changes
May 14, 2025
Collaborator
dongqui
left a comment
dongqui
left a comment
There was a problem hiding this comment.
미진님 프로젝트가 끝난 이후에도 불태우고 계시는군요! 👍 💯
타입 스크립트는 잘 적용해 주셨습니다~! 일부 상태 값 중복이나 복잡도를 조금만 더 신경 써주시면 더욱 좋을 거 같아요 :)
| import ConfirmModal from '@/components/ui/ConfirmModal'; | ||
|
|
||
| function Login() { | ||
| const [email, setEmail] = useState(''); |
Collaborator
There was a problem hiding this comment.
점점 상태 값이 늘어나죠.. 🤣 react-hook-form을 써보셔도 좋아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
주요 변경사항
src/components/TagBox.jsx→ 중복을 관리할 때 Setsrc/components/ui/Modal.jsx→ React portalsrc/components/ui/UserInfo.jsx→ UserImg는 소문자src/pages/Additem.jsx→ [e.target.id]: value 으로 반복 줄임src/pages/ItemsBox.jsx→ 관련된 코드들을 각각의 컴포넌트나 훅안에src/pages/ItemsBox.jsx57 줄 → 쿼리 상태 값 하나로src/pages/Product/AllItems.jsx→ form 내부 input에서 enter이벤트가 발생하면 submit 이벤트가 발생\hooks\useItems.jsx,\components\Product\AllItems.jsx→ 쿼리 상태 값이 두 개로 관리되면서 복잡도가 올라가고 예기치 못한 버그가 발생searchParamssrc/components/App.jsx→ 데이터가 적을 때 footer가 뜨는 문제, 데이터를 불러올 때마다 레이아웃 쉬프팅스크린샷
멘토에게