[김태욱] sprint3 #146
Merged
[김태욱] sprint3 #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongqui
approved these changes
May 15, 2025
Collaborator
dongqui
left a comment
dongqui
left a comment
There was a problem hiding this comment.
태욱님! 프로젝트 이후에도 불태워 주시는군요! 👍
기본적인 반응형에 대한 이해는 잘 하고 계신 거 같습니다! 요구 사항을 좀 더 꼼꼼하게 봐주시면 더욱 좋을 거 같아요 :)
| @media (max-width: 767px) { | ||
| #top-banner-text { | ||
| font-size: 32px; | ||
| line-height: 140%; |
Collaborator
There was a problem hiding this comment.
버튼도 영향을 받습니다 :) 너무 커지고 있어요!
| } | ||
|
|
||
| .feature img { | ||
| width: 696px; |
Collaborator
There was a problem hiding this comment.
width를 유연하게 하는 것이 좀 더 자연스러운 UI가 될 거 같네요 :)
Collaborator
There was a problem hiding this comment.
유연하게 대처하면서 뭔가 애매해진다 싶으면, 실무에서는 디자이너분과 상의하실 수 있습니다 :) 너무 어렵게 생각하지 않으셔도 괜찮아요!
| line-height: 140%; | ||
| } | ||
|
|
||
| br { |
| white-space: nowrap; | ||
| } | ||
|
|
||
| @media (max-width: 1199px) { |
Collaborator
There was a problem hiding this comment.
점진적으로 반응형을 잘 적용해 주셨네요~! 👍 👍
| color: #cfcfcf; | ||
| } | ||
|
|
||
| #footer-codeit { |
| justify-self: start; | ||
| } | ||
|
|
||
| #footer-Menu { |
Collaborator
Author
There was a problem hiding this comment.
여기 부분 grid 방식으로 줬어가지고 유연하게 반응형을 구현 할려면 이렇게 하는게 좋을거 같아 이렇게 했습니다 다만 faq 구역에 갭이 12px이라 이걸 더 늘려서 시안과 비슷하게 만들었습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
공통
랜딩 페이지
로그인, 회원가입 페이지 공통
심화
주요 변경사항
스크린샷
모바일 버젼 랜딩페이지
타블렛 버젼 랜딩페이지
모바일 버젼 로그인페이지 와 회원가입 페이지
멘토에게