[정지원] sprint4 #162
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,173 @@ | ||
| const emailRegex = | ||
| /^[0-9a-zA-Z]([-_\.]?[0-9a-zA-Z])*@[0-9a-zA-Z]([-_\.]?[0-9a-zA-Z])*\.[a-zA-Z]{2,3}$/; | ||
| const loginForm = document.getElementById("loginForm"); | ||
|
Collaborator
There was a problem hiding this comment. 변수명, 함수명이 대체로 명확하고 직관적입니다 :) 👍 |
||
| const signupForm = document.getElementById("signupForm"); | ||
| const emailInput = document.getElementById("email"); | ||
| const nicknameInput = document.getElementById("nickname"); | ||
| const passwordInput = document.getElementById("password"); | ||
| const confirmPasswordInput = document.getElementById("confirmPassword"); | ||
| const submitButton = document.getElementById("Submit-Button"); | ||
| let isEmailValid = false; | ||
| let isNicknameValid = false; | ||
| let isPasswordValid = false; | ||
| let isconfirmPasswordValid = false; | ||
|
|
||
| function showError(inputElement, errorId) { | ||
|
Collaborator
There was a problem hiding this comment. 여러개의 error span을 다루고 있는데, 하나로 줄여봐도 좋을 거 같습니다 :) function showError(inputElement, errorId, message) {
const errorElement = document.getElementById(errorId);
errorElement.style.display = "block";
errorElement.innerHTML= message;
inputElement.style.outline = "1px solid var(--error)";
} |
||
| const errorElement = document.getElementById(errorId); | ||
| errorElement.style.display = "block"; | ||
| inputElement.style.outline = "1px solid var(--error)"; | ||
| } | ||
| function hideError(inputElement, errorId) { | ||
|
|
||
| const errorElement = document.getElementById(errorId); | ||
| errorElement.style.display = "none"; | ||
| inputElement.style.outline = "none"; | ||
| } | ||
|
|
||
| function emailValidation() { | ||
| const emailValue = emailInput.value.trim(); | ||
| const emailValidation = emailRegex.test(emailValue); | ||
|
|
||
| isEmailValid = false; | ||
| hideError(emailInput, "email-value-empty"); | ||
| hideError(emailInput, "email-value-invalid"); | ||
|
|
||
| if (!emailValue) { | ||
| showError(emailInput, "email-value-empty"); | ||
| } else if (!emailValidation) { | ||
| showError(emailInput, "email-value-invalid"); | ||
| } else { | ||
| isEmailValid = true; | ||
| hideError(emailInput, "email-value-empty"); | ||
| hideError(emailInput, "email-value-invalid"); | ||
| } | ||
|
|
||
| submitButtonActivation(); | ||
| } | ||
|
|
||
| function nicknameValidation() { | ||
| const nicknameValue = nicknameInput.value.trim(); | ||
|
|
||
| isNicknameValid = false; | ||
| hideError(nicknameInput, "nickname-value-empty"); | ||
|
|
||
| if (!nicknameValue) { | ||
| showError(nicknameInput, "nickname-value-empty"); | ||
| } else { | ||
| isNicknameValid = true; | ||
| hideError(nicknameInput, "nickname-value-empty"); | ||
| } | ||
|
|
||
| submitButtonActivation(); | ||
| } | ||
|
|
||
| function passwordValidation() { | ||
| const passwordValue = passwordInput.value.trim(); | ||
|
|
||
| isPasswordValid = false; | ||
| hideError(passwordInput, "password-value-empty"); | ||
| hideError(passwordInput, "password-value-invalid"); | ||
|
|
||
| if (!passwordValue) { | ||
| showError(passwordInput, "password-value-empty"); | ||
| } else if (passwordValue.length < 8) { | ||
| showError(passwordInput, "password-value-invalid"); | ||
| } else { | ||
| isPasswordValid = true; | ||
| hideError(passwordInput, "password-value-empty"); | ||
| hideError(passwordInput, "password-value-invalid"); | ||
| } | ||
|
|
||
| submitButtonActivation(); | ||
| if (signupForm) { | ||
| confirmPasswordValidation(); | ||
| } | ||
| } | ||
|
|
||
| function confirmPasswordValidation() { | ||
| const confirmPasswordValue = confirmPasswordInput.value.trim(); | ||
|
|
||
| isconfirmPasswordValid = false; | ||
|
|
||
| hideError(confirmPasswordInput, "check-password-validation"); | ||
| hideError(confirmPasswordInput, "confirmPassword-value-invalid"); | ||
| if (!isPasswordValid) { | ||
| showError(confirmPasswordInput, "check-password-validation"); | ||
| } else if ( | ||
| !confirmPasswordValue || | ||
| confirmPasswordValue !== passwordInput.value.trim() | ||
| ) { | ||
| showError(confirmPasswordInput, "confirmPassword-value-invalid"); | ||
| } else { | ||
| isconfirmPasswordValid = true; | ||
| hideError(confirmPasswordInput, "check-password-validation"); | ||
| hideError(confirmPasswordInput, "confirmPassword-value-invalid"); | ||
| } | ||
|
|
||
| submitButtonActivation(); | ||
| } | ||
|
|
||
| function submitButtonActivation() { | ||
| let isAuthValid = isEmailValid && isPasswordValid; | ||
| if (signupForm) { | ||
| isAuthValid = isAuthValid && isNicknameValid && isconfirmPasswordValid; | ||
| } | ||
|
|
||
| submitButton.disabled = !isAuthValid; | ||
| } | ||
|
|
||
| if (emailInput) { | ||
| emailInput.addEventListener("focusout", emailValidation); | ||
| } | ||
| if (nicknameInput) { | ||
| nicknameInput.addEventListener("focusout", nicknameValidation); | ||
| } | ||
| if (passwordInput) { | ||
| passwordInput.addEventListener("input", passwordValidation); | ||
| } | ||
| if (confirmPasswordInput) { | ||
| confirmPasswordInput.addEventListener("input", confirmPasswordValidation); | ||
| } | ||
|
|
||
| submitButtonActivation(); | ||
|
Collaborator
There was a problem hiding this comment. 상태 초기화를 위해서인가요~? <button disabled></button> |
||
|
|
||
| if (loginForm) { | ||
| loginForm.addEventListener("submit", function (event) { | ||
| event.preventDefault(); | ||
| window.location.href = "items.html"; | ||
| }); | ||
| } | ||
|
|
||
| if (signupForm) { | ||
| signupForm.addEventListener("submit", function (event) { | ||
| event.preventDefault(); | ||
| window.location.href = "login.html"; | ||
| }); | ||
| } | ||
|
|
||
| function PasswordToggleVisibility(event) { | ||
| const targetButton = event.currentTarget; | ||
| const targetInputField = targetButton.parentElement.querySelector("input"); | ||
| const targetToggleIcon = targetButton.querySelector(".password-toggle-icon"); | ||
|
|
||
| const isPasswordVisible = targetInputField.type === "text"; | ||
| targetInputField.type = isPasswordVisible ? "password" : "text"; | ||
| targetToggleIcon.src = isPasswordVisible | ||
| ? "/images/icon/auth/eye-invisible.svg" | ||
| : "/images/icon/auth/eye-visible.svg"; | ||
|
|
||
| targetToggleIcon.alt = isPasswordVisible | ||
| ? "비밀번호 숨김 아이콘" | ||
| : "비밀번호 표시 아이콘"; | ||
|
|
||
| targetButton.setAttribute( | ||
| "aria-label", | ||
| isPasswordVisible ? "비밀번호 숨김" : "비밀번호 표시" | ||
| ); | ||
| } | ||
|
|
||
| const passwordToggleButtons = document.querySelectorAll( | ||
| ".password-toggle-button" | ||
| ); | ||
| passwordToggleButtons.forEach((passwordToggleButton) => | ||
| passwordToggleButton.addEventListener("click", PasswordToggleVisibility) | ||
| ); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
정규식을 써주셨네요! 👍