[홍승원] sprint11 #173
Merged
[홍승원] sprint11 #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongqui
approved these changes
May 22, 2025
Collaborator
dongqui
left a comment
dongqui
left a comment
There was a problem hiding this comment.
승원님! 한 단계 더 성장하신 느낌이 듭니다 👍 🤣
군더더기 없이 잘 구현해 주셨고, 앱 전반에서 로그인 상태를 어떻게 관리할지 고민해 보셔도 좋겠네요!
| handleSubmit, | ||
| setError, | ||
| formState: { errors, isSubmitting, isValid }, | ||
| } = useForm<z.infer<typeof signInSchema>>({ |
Collaborator
There was a problem hiding this comment.
react-hook-form에 zod까지..! 👍
| .string() | ||
| .nonempty({ message: "비밀번호 확인은 필수 입력입니다." }), | ||
| }) | ||
| .superRefine((data, context) => { |
| error ? "border-[1px] border-[#F74747]" : "" | ||
| }`} | ||
| /> | ||
| {type == "password" && |
Collaborator
There was a problem hiding this comment.
지금도 괜찮지만, 뒤에 붙는 아이콘이나 아이콘 클릭 이벤트 관련은 밖에서 처리하시면, 컴포넌트를 좀 더 확장성 있게 사용할 수 있겠네요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
주요 변경사항
스크린샷
멘토에게