Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added Image/desktop_01.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Image/desktop_02.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Image/desktop_03.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Image/desktop_04.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Image/desktop_05.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Image/ic_facebook.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Image/ic_instagram.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Image/ic_twitter.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Image/ic_youtube.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Image/logo.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Image/판다 얼굴.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
11 changes: 11 additions & 0 deletions faq.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Document</title>
</head>
<body>

</body>
</html>
82 changes: 82 additions & 0 deletions index.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,82 @@
<!DOCTYPE html>
<html lang="en">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<html lang="ko"> lang에 신경써주세요.
SEO, 접근성에 도움이 됩니다!

<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>판다마켓</title>
<title>Document</title>
<link rel="stylesheet" href="style.css">
</head>
<body>
<div class="container">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

main, header 등 시맨틱 태그에 좀 더 신경써주세요 :)

<div class="top_container">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
레이아웃을 다시 확인해주세요!

<img src="image/logo.png" class="logo">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

img를 쓰실 때 alt를 넣어주시는 것이 접근성에 좋습니다!

<a href="/login.html" class="login">
로그인
</a>
</div>
<div class ="layout_container">

<div class="layout_image">
<img src="image/desktop_01.png">
<a href="/items.html" class="product_view">
구경하러가기
</a>
</div>

<div class="layout_image">
<img src="image/desktop_02.png">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

텍스트 영역까지 이미지로 사용하셨군요..!
피그마를 보시면 해당 부분은 텍스트 영역과 이미지 영역이 구분되어 있습니다!

물론 급하게 작업해야하거나 간단하게 표현할 경우 지금 처럼 구현하는 것도 가능합니다 :)
하지만 HTML요소를 전부 이미지로 표현하면 몇 가지 문제점이 있습니다.

SEO
HTML의 텍스트는 검색 엔진 최적화(SEO)에 중요한 역할을 합니다. 이미지로 넣으면 검색 엔진이 내용을 인식하지 못해 사이트 SEO에 불리합니다!

접근성
이미지는 스크린리더가 읽을 수가 없어 접근성이 많이 떨어집니다.

유지보수성
만약 현재 상황에서 텍스트 색상 변경 요청이 들어오면 어떻게 될까요? 원래라면 css 한 줄만 수정하면 되겠지만, 지금의 경우 모든 이미지를 교체하게 되겠죠! 화면 크기에 따른 반응형 구현도 더 까다롭고 부자연스러워집니다!

성능
이미지는 HTML tag보다 로딩 속도에 더 많은 영향을 줍니다!

무엇보다 현재는 학습과정이므로 HTML로 직접 구현해보시는 것을 추천드려요 :)

</div>

<div class="layout_image">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

공통 스타일을 위한 클래스를 사용하셨네요! 👍

<img src="image/desktop_03.png">
</div>

<div class="layout_image">
<img src="image/desktop_04.png">
</div>

<div class="layout_image">
<img src="image/desktop_05.png">
</div>
<footer>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

하얀 여백이 생기고 있네요 😢


<div>
@codeit - 2024
</div>

<div style="display:flex; gap: 24px;">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inline style은 일관성이 떨어지고 유지 보수에 좋지 않아 지양하시는 것이 좋습니다~! :)


<a href="/privacy.html">
@privacy policy
</a>
<a href="/faq.html">
FAQ
</a>
</div style="display: flex">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

closing tag에는 속성을 넣지 않습니다!


<div>
<a href="https://www.facebook.com" target="_blank">
<img src="image/ic_facebook.png" alt="Facebook">
</a>

<a href="https://www.twitter.com" target="_blank">
<img src="image/ic_twitter.png" alt="Twitter">
</a>

<a href="https://www.youtube.com" target="_blank">
<img src="image/ic_youtube.png" alt="Youtube">
</a>

<a href="https://www.instagram.com" target="_blank">
<img src="image/ic_instagram.png" alt="Instagram">
</a>
</div>

</footer>
</div>

</div>

</body>
</html>
13 changes: 13 additions & 0 deletions items.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Document</title>
</head>
<body>
<div>
임시 아이템
</div>
</body>
</html>
14 changes: 14 additions & 0 deletions login.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Document</title>
</head>
<body>
<div>
임시로그인
</div>

</body>
</html>
11 changes: 11 additions & 0 deletions privacy.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Document</title>
</head>
<body>

</body>
</html>
124 changes: 124 additions & 0 deletions style.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,124 @@
*{
box-sizing: border-box;
}

a {
color: inherit;
text-decoration: none;
}
.container {
width: 100%;
}

.top_container{
display: flex;
justify-content: space-between;
}
footer{
background-color: #111827;
width: 100%;
height: 200px;
display: flex;
justify-content: space-between;
color: white;

}


/* 로고 */
.logo {
height: 50px;
width: 125px;
}

/* Spacer: 빈 공간 생성 */
.spacer {
flex: 1;
}

/* 로그인 */
.login {
display: flex;
justify-content: center;
align-items: center;
font-size: 16px;
border: 1px solid #3692FF;
border-radius: 10px;
color: white;
background-color: #3692FF;
width: 100px;
cursor: pointer;
}

.product_view{
display: flex;
justify-content: center;
align-items: center;
font-size: 16px;
border: 1px solid #3692FF;
border-radius: 999px;
color: white;
background-color: #3692FF;
width: 100px;
position: relative;
left:405px;
width: 360px;
bottom: 162px;
height: 61px;
cursor: pointer;

}
.layout_container{
display: flex;
flex-direction: column;
justify-content: center;
align-items: center;

}

.layout_image{
padding-top: 10px;
}

/* 화면 크기에 따라 여백 조정 */
@media screen and (min-width: 1920px) {
body {
background-color: skyblue;
margin: 0 auto;
}
}

/* 화면 너비가 1920px 미만일 때 배경색 없음 */
@media screen and (max-width: 1919px) {
body {
background-color: white; /* 기본 배경색 */


}

.logo{
margin-left: 200px;

}


}

/* 화면 너비에 따라 여백 조정 */
@media screen and (max-width: 1400px) {
.container {
padding: 0 100px;
}
}

@media screen and (max-width: 1024px) {
.container {
padding: 0 50px;
}
}

@media screen and (max-width: 768px) {
.container {
padding: 0 20px;
}
}
Loading