[이수정] Sprint 3 #39
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,74 +1,72 @@ | ||
| # 03. 스프린트 미션 3 | ||
|
|
||
| ## 요구사항 | ||
|
|
||
| ### 스프린트 미션 3 시안 | ||
|
|
||
| - [실습 과제 디자인 Figma](https://www.figma.com/design/IVkRlYWHY74QlgmxqA99Ym/%EC%8A%A4%ED%94%84%EB%A6%B0%ED%8A%B8-%EB%AF%B8%EC%85%98?node-id=63-3453) | ||
|
|
||
| ### 기본 요구사항 | ||
|
|
||
| - [x] 피그마 디자인에 맞게 페이지 생성 및 UI 라이브러리 미사용 | ||
| - [x] HTML, CSS 파일을 Netlify로 배포 | ||
| - 링크: https://fe-14-sprint-mission-basic-lsj.netlify.app/ | ||
|
|
||
| ### 체크리스트 [기본] | ||
|
|
||
| #### 공통 | ||
| - [x] 브라우저에 현재 보이는 화면의 영역(viewport) 너비를 기준으로 분기되는 반응형 디자인을 적용합니다. | ||
| - PC: 1200px ~ | ||
| - Tablet: 768px ~ 1199px | ||
| - Mobile: 375px ~ 767px | ||
|
|
||
| #### 랜딩 페이지 | ||
| - [x] 헤더 좌우 여백 수정 | ||
| - Tablet: 24px | ||
| - Mobile: 16px | ||
| - [x] 화면 영역이 줄어들면 “Privacy Policy”, “FAQ”, “codeit-2024”이 있는 영역과 SNS 아이콘들이 있는 영역의 간격이 줄어듭니다. | ||
|
|
||
| #### 로그인, 회원가입 페이지 | ||
| - [x] Tablet: 내부 디자인은 PC사이즈와 동일 | ||
| - [x] Mobile: 좌우 여백 16px, 내부 요소들이 너비를 모두 차지 | ||
| - [x] Mobile: 내부 요소 `max-width: 400px` | ||
|
|
||
| ### 체크리스트 [심화] | ||
|
|
||
| - [x] SNS에 랜딩 페이지(“/”) 공유 시 미리보기를 볼 수 있도록 메타 태그 설정 | ||
| - [x] 미리보기 제목은 “판다 마켓”, 설명은 “일상의 모든 물건을 거래해보세요”로 설정 | ||
|
|
||
| ## 주요 변경사항 | ||
|
|
||
| ### 스프린트 미션 2 리뷰 반영 | ||
| - [login.js](./scripts/login.js), [signup.js](./scripts/signup.js) | ||
| - 변수 지정 및 함수명 변경을 통한 가독성 확보 | ||
| - [login.html](./login.html), [signup.html](./signup.html) | ||
| - `<p>` 태그는 문단을 나타낼 때만 사용으로 변경 | ||
| - 비밀번호 확인 `<input type="checkbox" />`에서 `<button type="button" />`사용으로 변경 | ||
| - [login.css](./styles/login.css), [signup.css](./styles/signup.css) | ||
| - `signup.css`의 중복되는 스타일 제거 | ||
|
|
||
| ### 스프린트 미션 3 | ||
| - | ||
|
|
||
| ## 스크린샷 | ||
|
|
||
| ### 랜딩 페이지 헤더 - Tablet | ||
|  | ||
|
|
||
| ### 랜딩 페이지 헤더 - Mobile | ||
|  | ||
|
|
||
| ### 로그인 - Tablet | ||
|  | ||
|
|
||
| ### 회원가입 - Mobile | ||
|  | ||
|
|
||
| ### 랜딩 페이지 공유 | ||
|  | ||
|
|
||
| ## 멘토에게 | ||
|
|
||
| - |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,36 @@ | ||
| const emailInputField = document.getElementById("email"); | ||
| const pwdInputField = document.getElementById("pwd"); | ||
| const visiblilityBtn = document.getElementById("visibility"); | ||
| const loginBtn = document.getElementById("btn-submit-login"); | ||
|
|
||
| visiblilityBtn.addEventListener("click", onVisibilityChange); | ||
|
|
||
| emailInputField.addEventListener("change", onLoginInputChange); | ||
| pwdInputField.addEventListener("change", onLoginInputChange); | ||
|
|
||
| /** | ||
| * 비밀번호 입력 보기 버튼 클릭 로직 | ||
| * @param {*} e - 클릭 이벤트 | ||
| */ | ||
| function onVisibilityChange(e) { | ||
| if (e.target.classList.value.includes("checked")) { | ||
| visiblilityBtn.classList.remove("checked"); | ||
| pwdInputField.setAttribute("type", "password"); | ||
| } else { | ||
| visiblilityBtn.classList.add("checked"); | ||
| pwdInputField.setAttribute("type", "text"); | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * 로그인 버튼 활성화 로직 | ||
| */ | ||
| function onLoginInputChange() { | ||
| if (!loginBtn) return; | ||
| const email = emailInputField.value; | ||
| const pwd = pwdInputField.value; | ||
|
|
||
| // TODO: 입력 체크 로직 | ||
| if (email && pwd) loginBtn.removeAttribute("disabled"); | ||
| else loginBtn.setAttribute("disabled", "true"); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,27 +1,40 @@ | ||
| const nicknameInputField = document.getElementById("nickname"); | ||
| const pwdCheckInputField = document.getElementById("pwd-check"); | ||
| const visiblilityAgainBtn = document.getElementById("visibility-again"); | ||
| const signupBtn = document.getElementById("btn-submit-signup"); | ||
|
|
||
| visiblilityAgainBtn.addEventListener("click", onVisibilityAgainChange); | ||
|
|
||
| emailInputField.addEventListener("change", onSignupInputChange); | ||
| nicknameInputField.addEventListener("change", onSignupInputChange); | ||
|
Collaborator
There was a problem hiding this comment. form 이벤트 버블링 사용을 고려해보셔도 좋습니다~! |
||
| pwdInputField.addEventListener("change", onSignupInputChange); | ||
| pwdCheckInputField.addEventListener("change", onSignupInputChange); | ||
|
|
||
| /** | ||
| * 비밀번호 확인 입력 보기 버튼 클릭 로직 | ||
| * @param {*} e - 클릭 로직 | ||
| */ | ||
| function onVisibilityAgainChange(e) { | ||
| if (e.target.classList.value.includes("checked")) { | ||
| visiblilityAgainBtn.classList.remove("checked"); | ||
| pwdCheckInputField.setAttribute("type", "password"); | ||
| } else { | ||
| visiblilityAgainBtn.classList.add("checked"); | ||
| pwdCheckInputField.setAttribute("type", "text"); | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * 회원가입 버튼 활성화 로직 | ||
| */ | ||
| function onSignupInputChange() { | ||
| if (!signupBtn) return; | ||
| const email = emailInputField.value; | ||
| const nickname = nicknameInputField.value; | ||
| const pwd = pwdInputField.value; | ||
| const pwdCheck = pwdCheckInputField.value; | ||
|
|
||
| // TODO: 입력 체크 로직 | ||
| if (email && nickname && pwd && pwd === pwdCheck) signupBtn.removeAttribute("disabled"); | ||
| else signupBtn.setAttribute("disabled", "true"); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,10 +12,11 @@ | |
| href="https://cdn.jsdelivr.net/gh/orioncactus/[email protected]/dist/web/static/pretendard.min.css" | ||
| /> | ||
| <link rel="stylesheet" href="styles/global.css" /> | ||
| <link rel="stylesheet" href="styles/login.css" /> | ||
| <link rel="stylesheet" href="styles/signup.css" /> | ||
| </head> | ||
| <body> | ||
| <main class="form-wrapper flex-center gap-40" id="members"> | ||
| <a href="/"> | ||
| <img src="assets/images/logo/panda-market-logo.png" alt="로고 이미지" id="logo" /> | ||
| </a> | ||
|
|
@@ -36,19 +37,19 @@ | |
| <label for="pwd" class="text-2lg text-bold">비밀번호</label> | ||
| <div class="input-wrapper flex-sides radius-12"> | ||
| <input id="pwd" type="password" value="" placeholder="비밀번호를 입력해주세요" /> | ||
| <button type="button" alt="비밀번호 입력 보기" id="visibility" /> | ||
| </div> | ||
| </div> | ||
| <div class="input-field grid gap-16"> | ||
| <label for="pwd-check" class="text-2lg text-bold">비밀번호 확인</label> | ||
| <div class="input-wrapper flex-sides radius-12"> | ||
| <input id="pwd-check" type="password" value="" placeholder="비밀번호를 다시 한 번 입력해주세요" /> | ||
| <button type="button" alt="비밀번호 확인 입력 보기" id="visibility-again" /> | ||
|
Collaborator
There was a problem hiding this comment. alt는 img에만 유효합니다~! |
||
| </div> | ||
| </div> | ||
| <button type="submit" id="btn-submit-signup" disabled>회원가입</button> | ||
| <div class="flex-sides radius-8" id="sns-login-wrapper"> | ||
| <div class="text-lg text-medium">간편 로그인 하기</div> | ||
| <ul id="sns-login" class="flex-right gap-16"> | ||
| <li> | ||
| <a href="https://www.google.com/"> | ||
|
|
@@ -68,6 +69,7 @@ | |
| </p> | ||
| </form> | ||
| </main> | ||
| <script src="./scripts/login.js"></script> | ||
|
Collaborator
There was a problem hiding this comment. 여유가 되신다면 공통 로직을 뽑아서 함수로 정의해보셔도 좋을 거 같아요! 유효성 검사라던가, 비밀번호 보기 로직 같은 것들이요~ :) |
||
| <script src="./scripts/signup.js"></script> | ||
| </body> | ||
| </html> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
og 잘 넣어주셨네요~! 👍