Basic 이윤승 sprint1 #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongqui
approved these changes
Jan 24, 2025
Collaborator
dongqui
left a comment
dongqui
left a comment
There was a problem hiding this comment.
윤승님 고생 많으셨습니다~!
군더더기 없이 잘 마무리 해주셨습니다. 요구 사항을 조금만 더 꼼꼼하게 챙겨주시면 더 좋을 거 같습니다 :)
| @@ -0,0 +1,126 @@ | |||
| <!DOCTYPE html> | |||
| <html lang="ko"> | |||
| <div class="container"> | ||
| <header> | ||
| <a href="/"> | ||
| <img src="/img/logo.png" alt="logo" class="logo"> |
| margin: 0 auto; | ||
| } | ||
|
|
||
| header { |
Collaborator
There was a problem hiding this comment.
지금은 css 파일이 하나라 괜찮지만, 태그에 직접 스타일을 주게 되면 페이지 전체에 영향을 주기 때문에 지양하시는 것이 좋습니다!! 되도록 클래스를 이용해주세요~ :)
| height: 20px; | ||
| } | ||
|
|
||
| @media (max-width: 1120px) { |
| } | ||
| } | ||
|
|
||
| @media (max-width: 800px) { |
Collaborator
There was a problem hiding this comment.
아마 미션 3에서 더 하시겠지만, break-point도 확인해주세요 :)
| height: 300px; | ||
| } | ||
|
|
||
| .function-block img { |
Collaborator
There was a problem hiding this comment.
화면에 따라 이미지가 줄어들다보니 짓눌리는 현상이 있습니다!
미션3 때 조금 더 신경써주세요 :)
| .function-block { | ||
| width: 988px; | ||
| display: flex; | ||
| justify-content: space-around; |
Collaborator
There was a problem hiding this comment.
특정 구간에서 텍스트 영역과 이미지가 벌어지네요! space-around는 요구사항과 맞지 않는 거 같습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
주요 변경사항
스크린샷
멘토에게