[이유진] Sprint 3 #44
Merged
[이유진] Sprint 3 #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongqui
approved these changes
Jan 27, 2025
Collaborator
dongqui
left a comment
dongqui
left a comment
There was a problem hiding this comment.
유진님 고생 많으셨습니다!
군더더기 없이 깔끔하게 잘 해주셨네요! 요구 사항도 꼼꼼하게 챙겨주셨고 css에 능숙하신 거 같습니다 👍
| <div class="inner"> | ||
| <div class="head-logo"> | ||
| <h1><a href="./"><img src="./resource/img/head_logo.png" alt="판다마켓 로고"></a></h1> | ||
| <h1><a href="./"><img class="pc tablet" src="./resource/img/head_logo.png" alt="판다마켓 로고"><img class="mobile" src="./resource/img/head_logo_mo.png" alt="판다마켓 로고"></a></h1> |
Collaborator
There was a problem hiding this comment.
반응형 이미지로 picture를 사용해보시면 좋아요!
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/picture
|
|
||
|
|
||
| /* 반응형 */ | ||
| .mobile { |
Collaborator
There was a problem hiding this comment.
늘 재사용성이나 공통 부분을 생각하고 정의 하시려는 게 코드에 나타나는 거 같아요💯
| 반응형 | ||
| */ | ||
| /* tablet */ | ||
| @media (width < 1200px) { |
| } | ||
| .contents .main-cont { | ||
| padding: 24px; | ||
| background: #fcfcfc; |
Collaborator
There was a problem hiding this comment.
잘 정의 해주신 변수를 활용하시면 이후에 유지 보수에 좋습니다 :)
| width: 100%; | ||
| height: auto; | ||
| padding: 0; | ||
| order: 0; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
주요 변경사항
스크린샷
멘토에게